Download paths are not built with appamor encapsulation in mind
Bug #1222901 reported by
Manuel de la Peña
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-download-manager |
Fix Released
|
Critical
|
Manuel de la Peña | ||
ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The object paths of the downloads are built at random when they should have the app_id in the path when possible to ensure that click apps do not play with other app downloads.
Related branches
lp:~mandel/ubuntu-download-manager/use-apparmor
- Roberto Alsina (community): Approve
- Diego Sarmentero (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 1953 lines (+475/-294)25 files modifiedlibubuntudownloadmanager/apparmor.cpp (+13/-9)
libubuntudownloadmanager/apparmor.h (+4/-2)
libubuntudownloadmanager/download.cpp (+3/-3)
libubuntudownloadmanager/download.h (+2/-1)
libubuntudownloadmanager/download_factory.cpp (+40/-46)
libubuntudownloadmanager/download_factory.h (+10/-7)
libubuntudownloadmanager/download_manager.cpp (+30/-13)
libubuntudownloadmanager/download_manager.h (+2/-1)
libubuntudownloadmanager/download_queue.cpp (+5/-6)
libubuntudownloadmanager/download_queue.h (+3/-1)
libubuntudownloadmanager/group_download.cpp (+22/-31)
libubuntudownloadmanager/group_download.h (+7/-6)
libubuntudownloadmanager/single_download.cpp (+12/-12)
libubuntudownloadmanager/single_download.h (+7/-6)
ubuntu-download-manager-tests/fake_download.cpp (+6/-6)
ubuntu-download-manager-tests/fake_download.h (+7/-6)
ubuntu-download-manager-tests/fake_download_factory.cpp (+16/-9)
ubuntu-download-manager-tests/fake_download_factory.h (+15/-11)
ubuntu-download-manager-tests/fake_download_queue.cpp (+3/-2)
ubuntu-download-manager-tests/fake_download_queue.h (+3/-2)
ubuntu-download-manager-tests/test_download.cpp (+122/-41)
ubuntu-download-manager-tests/test_download_manager.cpp (+23/-14)
ubuntu-download-manager-tests/test_download_queue.cpp (+9/-5)
ubuntu-download-manager-tests/test_downloads_db.cpp (+12/-6)
ubuntu-download-manager-tests/test_group_download.cpp (+99/-48)
Changed in ubuntu-download-manager: | |
importance: | High → Critical |
Changed in ubuntu-download-manager: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-download-manager at revision 119, scheduled for release in ubuntu- download- manager, milestone 0.3