Neutron send 'network' notification without id

Bug #1222737 reported by Julien Danjou
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
High
Feilong Wang
neutron
Invalid
Undecided
Unassigned

Bug Description

2013-09-09 09:19:21.765 2362 INFO ceilometer.network.notifications [-] network notification {u'_context_roles': [u'admin'], u'priority': u'INFO', u'_context_read_deleted': u'no', u'event_type': u'network.create.start', u'timestamp': u'2013-09-09 09:19:01.895216', u'_context_tenant_id': u'dd91e0d407164ffca03818278c0b4ad7', u'payload': {u'network': {u'tenant_id': u'273b10bdfb4148f5a41d28477f8b4137', u'name': u'private', u'admin_state_up': True}}, u'_unique_id': u'7fb2a2d8a3b2453c85d2331db872b24c', u'_context_is_admin': True, u'_context_project_id': u'dd91e0d407164ffca03818278c0b4ad7', u'_context_timestamp': u'2013-09-09 09:19:01.778051', u'_context_user_id': u'a832259047f74538abd0b10cec85cba2', u'publisher_id': u'network.devstack-precise-hpcloud-az2-234994', u'message_id': u'e0aa1030-4b21-4731-a4a4-bb8337b2f2b5'}
2013-09-09 09:19:21.765 2362 AUDIT ceilometer.pipeline [-] Flush pipeline meter_pipeline
2013-09-09 09:19:21.765 2362 AUDIT ceilometer.pipeline [-] Flush pipeline cpu_pipeline
2013-09-09 09:19:21.765 2362 ERROR stevedore.extension [-] error calling 'network': 'id'
2013-09-09 09:19:21.765 2362 ERROR stevedore.extension [-] 'id'
2013-09-09 09:19:21.765 2362 TRACE stevedore.extension Traceback (most recent call last):
2013-09-09 09:19:21.765 2362 TRACE stevedore.extension File "/usr/local/lib/python2.7/dist-packages/stevedore/extension.py", line 145, in _invoke_one_plugin
2013-09-09 09:19:21.765 2362 TRACE stevedore.extension response_callback(func(e, *args, **kwds))
2013-09-09 09:19:21.765 2362 TRACE stevedore.extension File "/opt/stack/new/ceilometer/ceilometer/collector/service.py", line 258, in _process_notification_for_ext
2013-09-09 09:19:21.765 2362 TRACE stevedore.extension p(list(ext.obj.to_samples(notification)))
2013-09-09 09:19:21.765 2362 TRACE stevedore.extension File "/opt/stack/new/ceilometer/ceilometer/network/notifications.py", line 86, in process_notification
2013-09-09 09:19:21.765 2362 TRACE stevedore.extension resource_id=message['payload']['id'],
2013-09-09 09:19:21.765 2362 TRACE stevedore.extension KeyError: 'id'
2013-09-09 09:19:21.765 2362 TRACE stevedore.extension

from http://logs.openstack.org/37/39237/7/check/gate-tempest-devstack-vm-neutron/42d7fba/logs/screen-ceilometer-collector.txt.gz

Julien Danjou (jdanjou)
Changed in ceilometer:
status: New → Confirmed
importance: Undecided → High
milestone: none → havana-rc1
Revision history for this message
Feilong Wang (flwang) wrote :

I think the root cause is when the network.create.start notification sending, there is no network id assigned. See https://github.com/openstack/neutron/blob/master/neutron/api/v2/base.py#L334

Seems most of the create.start notifications have the same issues. I will confirm that.

Revision history for this message
Mark McClain (markmcclain) wrote :

Correct. *.create.start events do not have a resource ID assigned.

Changed in neutron:
status: New → Invalid
Revision history for this message
Yang Yu (yuyangbj) wrote : I will be on vacation from 9/5 to 9/15, urgent call: 13811509950

I will be out of the office starting 2013-09-05 and will not return until
2013-09-15.

I will be on my marriage leave from 9/5 to 9/15, for any urgent issue
please call me before 9/7.

For daily work, please ask my scrum master Zhu Zhu for help.
For glance issue, please ask glance SME Feilong Wang for help.
For defect report, there will be no report next week.

Feilong Wang (flwang)
Changed in ceilometer:
assignee: nobody → Fei Long Wang (flwang)
Feilong Wang (flwang)
Changed in ceilometer:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/45833

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/45833
Committed: http://github.com/openstack/ceilometer/commit/4e21e094017d044ad1666104f14519cf0be31949
Submitter: Jenkins
Branch: master

commit 4e21e094017d044ad1666104f14519cf0be31949
Author: Fei Long Wang <email address hidden>
Date: Tue Sep 10 15:06:41 2013 +0800

    Drop the *.create.start notification for Neutron

    Based on current implement, there is no resource id assigned
    when *.create.start notification sending, so Ceilometer will
    run into KeyError. So this fix will drop the *.create.start
    notification because the meter can't be linked to correct
    resource. Besides the info can be collected by *.create.end.

    Fixes bug 1222737

    Change-Id: I785ae1ca1383dc5f9afbf2ab072a6e1efc582606

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.