No nedd to init testr explicitly

Bug #1222688 reported by Kui Shi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
Medium
Kui Shi

Bug Description

    Don't need to init testr in run_tests.sh

    In run_tests.sh, function init_testr will initialize testr if the
    directory .testrepository is not existed. Actually, testr will do
    the check before run the test:

    In Python package testrepository, setuptools_command.py:Testr.run

    68 def run(self):
    69 """Set up testr repo, then run testr"""
    70 if not os.path.isdir(".testrepository"):
    71 self._run_testr("init")

    So, init_testr can be removed safely.

Kui Shi (skuicloud)
Changed in oslo:
assignee: nobody → Kui Shi (skuicloud)
Changed in oslo:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/46635
Committed: http://github.com/openstack/oslo-incubator/commit/1197f8a9e0044467fb307bd1e984d4f4ab772890
Submitter: Jenkins
Branch: master

commit 1197f8a9e0044467fb307bd1e984d4f4ab772890
Author: Kui Shi <email address hidden>
Date: Sat Sep 14 17:07:50 2013 +0800

    Don't need to init testr in run_tests.sh

    In run_tests.sh, function init_testr will initialize testr if the
    directory .testrepository is not existed. Actually, testr will do
    the check before run the test:

    In Python package testrepository,
    setuptools_command.py:Testr.run

    68 def run(self):
    69 """Set up testr repo, then run testr"""
    70 if not os.path.isdir(".testrepository"):
    71 self._run_testr("init")

    So, init_testr can be removed safely.

    Fixes Bug #1222688
    Change-Id: I51e73efe4e9b80bbf0159a5bce0db81fc049b9ce

Changed in oslo:
status: In Progress → Fix Committed
Mark McLoughlin (markmc)
Changed in oslo:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in oslo:
milestone: none → havana-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.