openstack provider Instances suppresses errors

[John A Meinel]

The code in the openstack provider's implementation of Instances suppresses any errors generated while running collectInstances.

Specifically, the code gets in a list of ids to check on, and an "out" parameter with information about the ones it found. And then a list of Ids it was unable to process.

However, if you get an error calling GetServer or ListServersDetail, it just returns the list of Ids passed in.

At a minimum, it should probably log the error.

The issue is that it treats all errors as non-fatal. I ran into this trying to test the HTTP disable-hostname-validation. As we get Certificate failures there, but Instances just returns the "no instances found" error.