Sample-Create accepts invalid counter_types.

Bug #1221007 reported by Nisha Kadakia
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
gordon chung

Bug Description

sample-create subcommand works perfectly fine with meter_type as gauge, cumulative, or delta, however it doesn't complain if argument values other than these are passed. Example:- I misspelled gauge as guage and the command execution worked fine with no errors reported. Checked the mongo DB and the type was captured as guage.

After execution of above command with invalid argument, other sub commands fail to execute. Example:- meter-list stopped working because it expects only valid values.

Ideally sample-create command execution should throw errors when invalid argument values are passed. This probably will automatically take care of other subsequent errors

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/45344

Changed in ceilometer:
assignee: nobody → gordon chung (chungg)
status: New → In Progress
Lianhao Lu (lianhao-lu)
Changed in ceilometer:
milestone: none → havana-rc1
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/45344
Committed: http://github.com/openstack/ceilometer/commit/42d910d820a4d4fa58ed5f29e00e58793afbb306
Submitter: Jenkins
Branch: master

commit 42d910d820a4d4fa58ed5f29e00e58793afbb306
Author: Gordon Chung <email address hidden>
Date: Thu Sep 5 19:08:07 2013 -0400

    validate counter_type when posting samples

    check to ensure counter_type is valid when posting samples via API

    Change-Id: I097c54f6b410c67b117b07eaf146828766f4852a
    Fixes: bug #1221007

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.