brick lvm pep8 violation in Nova

Bug #1220849 reported by Walt Boring
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Critical
Walt Boring

Bug Description

pep8 tests against brick in Nova now yields a violation in lvm.py

1d/1z [stack@cld4b5ubuntu:~/openstack/nova] bp/refactor-iscsi-fc-brick(+6/-6)+ ± ./run_tests.sh -p
Running flake8 ...
./nova/brick/local_dev/lvm.py:25:1: H302 import only modules.'from itertools import izip' does not import a module

Tags: brick
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/45090

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/45090
Committed: http://github.com/openstack/cinder/commit/9faa32599cf86c4111d0d6cd0a7c377061f2ee6d
Submitter: Jenkins
Branch: master

commit 9faa32599cf86c4111d0d6cd0a7c377061f2ee6d
Author: Walter A. Boring IV <email address hidden>
Date: Wed Sep 4 11:27:17 2013 -0700

    Fixes brick Nova pep8 violation for lvm.py

    Running pep8 tests in Nova gives a violation
    in lvm.py for not importing a module. This
    is a simple fix to import the module itself
    instead of only importing a function in the
    module.

    Fixes bug #1220849

    Change-Id: Idc603dcfab18601dd4246c623d34be5933434f84

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.