gschem crashes in g_current_window

Bug #1220824 reported by Nathan Stewart
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
Critical
Unassigned

Bug Description

Current trunk build () crashes with ERROR: Found invalid gschem window smob #f
if the attribute window is launched.

Ubuntu 12.04
Guile 1.8.8
gEDA/gschem version 1.9.0.20121203 (4e2417d23eec6837b71ccca6c46835efdd51020c)

Launch gschem
Right click anywhere, Add Net ,Bus, Attribute, etc..
Observe crash

Anything calling g_current_window appears to crash with the invalid window smob error.

Tags: gschem
Peter TB Brett (peter-b)
Changed in geda:
status: New → In Progress
importance: Undecided → Critical
assignee: nobody → Peter TB Brett (peter-b)
Peter TB Brett (peter-b)
tags: added: gschem
Changed in geda:
milestone: none → 1.9.1
Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

Bug was fixed by a commit
git master commit 9821203640ff8599b1a837d5769461955e86af91
http://git.geda-project.org/geda-gaf/commit/?id=9821203640ff8599b1a837d5769461955e86af91

commit 9821203640ff8599b1a837d5769461955e86af91
Author: Peter TB Brett <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Make popup menu work in a similar way to menu bar. [1220824]

    Re-write the popup menu code to work the same way as the main menu bar
    does (more-or-less). This includes dispatching actions via Scheme and
    rendering icons, although the popup menu doesn't list keybindings to
    save screen area (this could change if people want it to).

    The popup menu still operates from a static array defining the menu
    items, because I didn't have time to make it load its definitions from
    Scheme yet.

    This fixes a crash bug where the popup menu was calling functions that
    expected to be being dispatched via Scheme and didn't have the context
    that they needed.

    Closes-bug: lp-1220824
    Reported-by: Nathan Stewart <email address hidden>

Changed in geda:
status: In Progress → Fix Committed
Revision history for this message
Nathan Stewart (therealnathanstewart) wrote : Re: [Bug 1220824] Re: gschem crashes in g_current_window

Now this is interesting, as manipulating the popup menu from a plugin is
something I'm actually trying to arrive at eventually. What's involved in
populating the popup menu from scheme?

On Wed, Sep 4, 2013 at 5:28 PM, gpleda.org commit robot <
<email address hidden>> wrote:

> Bug was fixed by a commit
> git master commit 9821203640ff8599b1a837d5769461955e86af91
>
> http://git.geda-project.org/geda-gaf/commit/?id=9821203640ff8599b1a837d5769461955e86af91
>
> commit 9821203640ff8599b1a837d5769461955e86af91
> Author: Peter TB Brett <email address hidden>
> Commit: Peter TB Brett <email address hidden>
>
> gschem: Make popup menu work in a similar way to menu bar. [1220824]
>
> Re-write the popup menu code to work the same way as the main menu bar
> does (more-or-less). This includes dispatching actions via Scheme and
> rendering icons, although the popup menu doesn't list keybindings to
> save screen area (this could change if people want it to).
>
> The popup menu still operates from a static array defining the menu
> items, because I didn't have time to make it load its definitions from
> Scheme yet.
>
> This fixes a crash bug where the popup menu was calling functions that
> expected to be being dispatched via Scheme and didn't have the context
> that they needed.
>
> Closes-bug: lp-1220824
> Reported-by: Nathan Stewart <email address hidden>
>
> ** Changed in: geda
> Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1220824
>
> Title:
> gschem crashes in g_current_window
>
> Status in GPL Electronic Design Automation tools:
> Fix Committed
>
> Bug description:
> Current trunk build () crashes with ERROR: Found invalid gschem window
> smob #f
> if the attribute window is launched.
>
> Ubuntu 12.04
> Guile 1.8.8
> gEDA/gschem version 1.9.0.20121203
> (4e2417d23eec6837b71ccca6c46835efdd51020c)
>
> Launch gschem
> Right click anywhere, Add Net ,Bus, Attribute, etc..
> Observe crash
>
> Anything calling g_current_window appears to crash with the invalid
> window smob error.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/geda/+bug/1220824/+subscriptions
>

Peter TB Brett (peter-b)
Changed in geda:
assignee: Peter TB Brett (peter-b) → nobody
Peter TB Brett (peter-b)
Changed in geda:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.