Create Router on network topology fails

Bug #1219078 reported by David Lyle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Ladislav Smola

Bug Description

Continuing to play with the interface... I discovered clicking the Create Router button on the Network Topology Panel reports an error and
"GET /project/network_topology/createrouter HTTP/1.1" 500 27705
appears on the command line.

David Lyle (david-lyle)
Changed in horizon:
milestone: none → havana-3
David Lyle (david-lyle)
description: updated
Changed in horizon:
milestone: havana-3 → havana-rc1
importance: Undecided → High
status: New → Confirmed
Ladislav Smola (lsmola)
Changed in horizon:
assignee: nobody → Ladislav Smola (lsmola)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/45242

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Ladislav Smola (lsmola) wrote :

That was a piece of cake, there was just missing ' around the urls.

Though I see 2 other flaws here:
1. It duplicates the templates, that are in other places. It should have tests for them. Even better will be, not to duplicate the templates, but rather use the general one, and put there the links as variables. Then I guess the tests are not necessary, though I would like to have the simple ones anyway. Just check, that it renders and uses the correct templates.

2. I should be able to set the gateway during the creation of the router. Because after I create a router on network topology page, I have to go all the way to the router lists to set the gateway. So I should be able to do that during creating process, or right in the network topology page.
The edit of gateway should be available on the network topology page.

Not sure if there should be new bugs for ^^, or it can be addressed here. Or if it can be ignored? It should not take much time to fix those.

Revision history for this message
David Lyle (david-lyle) wrote :

lsmola -- Please add new bugs for the other issues you've found.

Revision history for this message
Ladislav Smola (lsmola) wrote :

new bugs added

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/45242
Committed: http://github.com/openstack/horizon/commit/9a8b8d757e328553be5581d1799c4241e30fc2d4
Submitter: Jenkins
Branch: master

commit 9a8b8d757e328553be5581d1799c4241e30fc2d4
Author: Ladislav Smola <email address hidden>
Date: Thu Sep 5 16:50:38 2013 +0200

    Create Router on network topology fails

    - just wrong definition of urls, missing '
    - also add '{% load url from 'future' %} to maintain Django 1.4
      compatibility

    Fixes bug 1219078

    Change-Id: I661ab0561bab24c1af864a7fbd0e6913f6dfed06

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.