virt drivers should raise NotImplementedError instead of pass for plug_vifs

[Matt Riedemann]

The hyperv, docker, vmware and powervm drivers should be changed to raise NotImplementedError from the plug_vifs methods rather than pass. See change https://review.openstack.org/#/c/43955/ and bug 1217586.

The compute manager has to handle the NotImplementedError case when initializing the host, that's why they simply pass today.

This is a low priority bug but should probably be targeted for Icehouse.

[Gary Kotton (garyk)]

The VMware driver already has the pass. The fix just adds in the log messages.
Thanks
Gary

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/44606

[Gary Kotton (garyk)]

Original bug was: virt drivers should raise NotImplementedError instead of pass for plug_vifs
This would cause tempest to fail. The implementation was reverted to add a debug message...

[Matt Riedemann (mriedem)]

Gary, I don't know why you changed the title of the bug, but adding debug log messages in the virt drivers is not the intent of the bug, it's to change the pass in the virt driver to raise NotImplementedError.

If the powervm code review linked in the description is confusing, I'm sorry, but the title and rest of the description seems pretty clear to me.

[Matt Riedemann (mriedem)]

Gary, also, to be clear, the original original bug was I wanted to change the pass to NotImplementedError in the powervm driver specifically to make tempest fail when using powervm and running tests against unimplemented APIs, because otherwise we were getting false positives. The problem was when I implemented that, it caused the compute service to fail on startup, so I had to revert back to pass (from raise NotImplementedError) and I added a debug log message (which wasn't in the powervm driver initially). That was a short-term fix for havana and I discussed it with Joe Gordon - he thought it was better to revert rather than try to tackle handling NotImplementedError in the compute manager late in havana. That is the impetus of this bug - to go back to raising NotImplementedError rather than pass but handle it properly in the compute manager.

[Matt Riedemann (mriedem)]

Patch was abandoned so changed status back to Triaged.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/47618

[Matt Riedemann (mriedem)]

Hmm, for some reason I can't access the review link above?

[Arnaud Legendre (arnaudleg)]

The review is still a draft, I am not sure why it updated this page.
I am working on it: in progress.

[Matt Riedemann (mriedem)]

Removing the havana-rc1 tag again as that's for critical bug fixes which must make the havana release at this point. This is not a critical bug fix, this is more of a cleanup bug.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/47618
Committed: http://github.com/openstack/nova/commit/6ef9262a6aa39b2da8023067386b832a35ecc45c
Submitter: Jenkins
Branch: master

commit 6ef9262a6aa39b2da8023067386b832a35ecc45c
Author: Arnaud Legendre <email address hidden>
Date: Fri Sep 20 08:10:13 2013 +0000

    plug_vif raise NotImplementedError instead of pass

    The Hyper-V, VMware, Docker and PowerVM drivers raise
    NotImplementedError from the plug_vifs and unplug_vifs
    methods rather than pass.
    The compute manager handles the NotImplementedError
    case when initializing the host.

    Fixed bug 1218593

    Change-Id: Id17a1f691f46816eadfe257d9ac0cc46502318ef

[Matt Riedemann (mriedem)]

Fixes were released in havana.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/83574

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/83574
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fec6bc0beceba7c67cbe8541fc45f3b441872893
Submitter: Jenkins
Branch: stable/havana

commit fec6bc0beceba7c67cbe8541fc45f3b441872893
Author: Arnaud Legendre <email address hidden>
Date: Fri Sep 20 08:10:13 2013 +0000

    plug_vif raise NotImplementedError instead of pass

    The Hyper-V, VMware, Docker and PowerVM drivers raise
    NotImplementedError from the plug_vifs and unplug_vifs
    methods rather than pass.
    The compute manager handles the NotImplementedError
    case when initializing the host.

    Fixed bug 1218593

    (cherry picked from commit 6ef9262a6aa39b2da8023067386b832a35ecc45c)

    Conflicts:

     nova/tests/virt/hyperv/test_hypervapi.py
     nova/tests/virt/vmwareapi/test_vmwareapi.py
    Change-Id: Id17a1f691f46816eadfe257d9ac0cc46502318ef