lxc-create help text error

[NeilGreenwood]

There is a typo in the output of
  lxc-create --help

specifically the --lxcpath line has 2 issues:
  1 It should start "-P, --lxcpath"
  2 It says "patch" instead of "path"

$ lxc-create --help
usage: lxc-create -n NAME [-f CONFIG_FILE] [-t TEMPLATE] [FS_OPTIONS] --
         [-P lxcpath] [TEMPLATE_OPTIONS]

where FS_OPTIONS is one of:
  -B none
  -B dir [--dir rootfs_dir]
  -B lvm [--lvname LV_NAME] [--vgname VG_NAME] [--fstype FS_TYPE]
    [--fssize FS_SIZE]
  -B btrfs

Create a new container on the system.

Options:
  -n NAME specify the name of the container
  -f CONFIG_FILE use an existing configuration file
  -t TEMPLATE use an accessible template script
  -B BACKING_STORE alter the container backing store (default: none)
  --lxcpath path specify an alternate container patch (default: /var/lib/lxc)
  --lvname LV_NAME specify the LVM logical volume name
                      (default: container name)
  --dir ROOTFS_DIR specify path for custom rootfs directory location
  --vgname VG_NAME specify the LVM volume group name (default: lxc)
  --fstype FS_TYPE specify the filesystem type (default: ext4)
  --fssize FS_SIZE specify the filesystem size (default: 500M)

To see template-specific options, specify a template. For example:
  lxc-create -t ubuntu -h

I have looked at the package source, and I can see that lxc-create.in needs the changes, but I don't know how to go about making them. I am very keen to help if I can.

ProblemType: Bug
DistroRelease: Ubuntu 13.04
Package: lxc 0.9.0-0ubuntu3.4
ProcVersionSignature: Ubuntu 3.8.0-27.40-generic 3.8.13.4
Uname: Linux 3.8.0-27-generic x86_64
NonfreeKernelModules: nvidia
ApportVersion: 2.9.2-0ubuntu8.3
Architecture: amd64
Date: Wed Aug 28 08:05:58 2013
EcryptfsInUse: Yes
InstallationDate: Installed on 2012-04-27 (487 days ago)
InstallationMedia: Ubuntu 12.04 LTS "Precise Pangolin" - Beta amd64 (20120328)
MarkForUpload: True
SourcePackage: lxc
UpgradeStatus: Upgraded to raring on 2013-04-26 (123 days ago)
lxcsyslog:

[Serge Hallyn (serge-hallyn)]

Hi,

thanks for submitting this bug. lxc-create, upstream, has been
converted from a script to a c file (lxc_create.c). We will
shortly be merging upstream lxc back into saucy, however that
won't go into raring (which you're using) - so this means you have
a choice :)

You were right to look at lxc-create.in. I'll be happy to guide you
through the process, but I'm not sure what you mean by "don't know how
to go about making them". I suspect you're asking about how the
package is created from the source, and specifically how lxc-create
is created from lxc-create.in? lxc-create is generated by autoconf,
which processes lxc-create.in in order to expand a few configurable
variables (like @DATADIR@). One way to download the source for
saucy (not sure which way you did it) is

 pull-lp-source lxc
 cd lxc-0.9.0

The package is in 'quilt 3.0' format, which means changes to any
source need to be done using patches under debian/patches. The
easiest way for you to do this would be to first create the new
(empty) patch using

 quilt new 0015-fix-lxc-create-help-text

then edit lxc-create.in using the command

 quilt edit src/lxc/lxc-create.in

After making and saving your changes, you can update the patch
using

 quilt refresh

Now debian/patches/0015-fix-lxc-create-help-text contains your patch.
You can simply attach that file to this bug if you like. If you want
to build the package so as to test it, you can install all the lxc
build dependencies using

 sudo apt-get build-dep lxc

then build the package using

 debian/rules build && fakeroot debian/rules binary

This will generate .deb files which you can install to test the package.

  status: confirmed
  importance: low

[NeilGreenwood (neil-greenwood)]

Thanks Serge, that was exactly the help I was wanting.

[NeilGreenwood (neil-greenwood)]

Here's my patch for raring.

I built the 64-bit debs and installed them in a chroot, everything looks fine.
I built the 32-bit debs in a 32-bit chroot and installed them, and they look good too.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "0016-fix-lxc-create-help-text" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Serge Hallyn (serge-hallyn)]

Thanks - the patch looks good. Unfortunately I dragged my feet too long, and we now no longer have the lxc-create.in script in saucy. I've pushed the equivalent patch (just adding '-P' to the help text) to the mailing list.

[NeilGreenwood (neil-greenwood)]

There was an additional change on the same line (removing a letter, "patch"
-> "path" iirc). Did you include that change too?

Neil
On 18 Sep 2013 20:01, "Serge Hallyn" <email address hidden> wrote:

> Thanks - the patch looks good. Unfortunately I dragged my feet too
> long, and we now no longer have the lxc-create.in script in saucy. I've
> pushed the equivalent patch (just adding '-P' to the help text) to the
> mailing list.
>
> ** Changed in: lxc (Ubuntu)
> Status: Confirmed => Fix Committed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1217730
>
> Title:
> lxc-create help text error
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1217730/+subscriptions
>

[Serge Hallyn (serge-hallyn)]

Quoting NeilGreenwood (<email address hidden>):
> There was an additional change on the same line (removing a letter, "patch"
> -> "path" iirc). Did you include that change too?

That was already correct in the .c file