Patching of netbeans.conf does not work

[Marek Slama]

Binary package hint: netbeans5.5

Postinstall script should add path to Sun JDK 5 or 6 to /etc/netbeans5.5/netbeans/conf. But due to bug in logic it does not.

[Emmet Hikory (persia)]

Thank you for the patch. The fix to the postinst looks good and clean. I'm a little uncomforable with the changes to debian/rules, as follows:

1) There is no entry in the changelog explaining these changes
2) There is a comment in debian/rules noting debian/copyright preservation, but it would be removed.

    I have unsubscribed ubuntu-universe-sponsors pending resolution of these issues. Please resubscribe when they have been addressed to request upload.

[Marek Slama (mslama-email)]

Changes in debian/rules: This is target 'clean'. It is also invoked when source package is built.

1. As file debian/copyright file is generated from upstream source and files in debian/copyright-files it is actually redundant. To make reviewers' life easier we kept it in source package ie. rm of debian/copyright was commented out in debian/rules. Reviewers need not build binary package to see complete copyright file. I reversed this change. Disadvantage is that to get correct up to date version of debian/copyright one has to first build binary package to get regenerated file debian/copyright.

2. List files (second change in debian/rules) are auxiliary files. They are not necessary and should not be present in source package. I also added note to changelog.

Summary:
1. I reversed deletion of debian/copyright.
2. debian/copyright is now part of source package
3. changelog is updated - -rm -rf $(d_lists) is now performed in clean target.

[Emmet Hikory (persia)]

Thanks for the update. I've uploaded the changes. Please mark this bug "Fix Released" when it is distributed in the archives. This could have been automated by adding the text (LP: #121709) to the debian/changelog entry that closes the bug.

Separately, debian/copyright contains 3 copies of the Apache 1.1 license, 6 copies of CDDL 1.0 and 8 copies of the Apache 2.0 license. It may be preferable to include these licenses verbatim in source: debian/ and binary: usr/share/doc/netbeans5.5/ and only provide the locations(as e.g. "/usr/share/netbeans5.5/CDDL") in the copyright file, in the manner of the LGPL reference (or at least it might make it easier for a user to understand their rights and obligations). The other licenses are mostly singletons and the TOSC license is very short, so the rest are probably best in debian/copyright directly. Fixing this isn't worth a special upload, and it's not a blocker for this revision, but do consider it for inclusion in a future release.