Security groups with source groups no longer work

[Sam Morrison]

The fix for bug #1184041 has a side affect of breaking security group linking via source groups.

Example:

Secgroup "Server" has rule

+-------------+-----------+---------+----------+---------------+
| IP Protocol | From Port | To Port | IP Range | Source Group |
+-------------+-----------+---------+----------+---------------+
| tcp | 8140 | 8140 | | client |
+-------------+-----------+---------+----------+---------------+

Instance A is running and is associated with the "Server" secgroup

Now if a create a new instance with the "client" security group it should add a rule to instance A to all the new instance to talk to it.

This no longer gets added as it uses the cached version.

[Thierry Carrez (ttx)]

Might also affect Folsom/Grizzly as the fix was backported

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/45107

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/45107
Committed: http://github.com/openstack/nova/commit/8679b2c8e7f9fddc31a74ad00f6705bca00a762b
Submitter: Jenkins
Branch: master

commit 8679b2c8e7f9fddc31a74ad00f6705bca00a762b
Author: Vishvananda Ishaya <email address hidden>
Date: Wed Sep 4 12:41:26 2013 -0700

    Refresh network info cache for secgroups

    Before updating security group rules, we need to make sure that
    the info cache is up-to-date. Without this source groups are not
    updated properly. This was a regression introduced in commit
    85aac04704350566d6b06aa7a3b99649946c672c which fixed a potential
    DOS using source groups.

    Fixes bug 1216720

    Change-Id: I6b5115df53f2e159ea506ef966cd49cedd35f83d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/45274

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/45274
Committed: http://github.com/openstack/nova/commit/18f0264429e33f1f5165980de56bb37e49b2e336
Submitter: Jenkins
Branch: stable/grizzly

commit 18f0264429e33f1f5165980de56bb37e49b2e336
Author: Vishvananda Ishaya <email address hidden>
Date: Wed Sep 4 12:41:26 2013 -0700

    Refresh network info cache for secgroups

    Before updating security group rules, we need to make sure that
    the info cache is up-to-date. Without this source groups are not
    updated properly. This was a regression introduced in commit
    85aac04704350566d6b06aa7a3b99649946c672c which fixed a potential
    DOS using source groups.

    Fixes bug 1216720

    Conflicts:
     nova/network/manager.py
     nova/tests/network/test_manager.py

    Change-Id: I6b5115df53f2e159ea506ef966cd49cedd35f83d
    (cherry picked from commit 8679b2c8e7f9fddc31a74ad00f6705bca00a762b)