image upload - make_subprocess issue

[Mate Lakat]

It was discovered during:

stack@DevStackOSDomU:~/tempest$ nosetests tempest.api.compute.images.test_images_oneserver:ImagesOneServerTestXML.test_create_delete_image

[req-8593dd23-7383-49db-bad8-ac2e6fc41984 ImagesOneServerTestXML1808487469-user ImagesOneServerTestXML807215939-tenant] Exception during message han

Traceback (most recent call last):
  File "/opt/stack/nova/nova/openstack/common/rpc/amqp.py", line 421, in _process_data
    **args)
  File "/opt/stack/nova/nova/openstack/common/rpc/dispatcher.py", line 172, in dispatch
    result = getattr(proxyobj, method)(ctxt, **kwargs)
  File "/opt/stack/nova/nova/exception.py", line 88, in wrapped
    event_type, level, payload)
  File "/opt/stack/nova/nova/exception.py", line 76, in wrapped
    return f(self, context, *args, **kw)
  File "/opt/stack/nova/nova/compute/manager.py", line 241, in decorated_function
    pass
  File "/opt/stack/nova/nova/compute/manager.py", line 227, in decorated_function
    return function(self, context, *args, **kwargs)
  File "/opt/stack/nova/nova/compute/manager.py", line 269, in decorated_function
    e, sys.exc_info())
  File "/opt/stack/nova/nova/compute/manager.py", line 256, in decorated_function
    return function(self, context, *args, **kwargs)
  File "/opt/stack/nova/nova/compute/manager.py", line 2160, in snapshot_instance
    update_task_state)
  File "/opt/stack/nova/nova/virt/xenapi/driver.py", line 204, in snapshot
    self._vmops.snapshot(context, instance, image_id, update_task_state)
  File "/opt/stack/nova/nova/virt/xenapi/vmops.py", line 762, in snapshot
    image_id)
  File "/opt/stack/nova/nova/virt/xenapi/image/glance.py", line 68, in upload_image
    self._call_glance_plugin(session, 'upload_vhd', params)
  File "/opt/stack/nova/nova/virt/xenapi/image/glance.py", line 37, in _call_glance_plugin
    'glance', fn, CONF.glance_num_retries, pick_glance, **params)
  File "/opt/stack/nova/nova/virt/xenapi/driver.py", line 762, in call_plugin_serialized_with_retry
    return self.call_plugin_serialized(plugin, fn, *args, **kwargs)
  File "/opt/stack/nova/nova/virt/xenapi/driver.py", line 747, in call_plugin_serialized
    rv = self.call_plugin(plugin, fn, params)
  File "/opt/stack/nova/nova/virt/xenapi/driver.py", line 743, in call_plugin
    host, plugin, fn, args)
  File "/opt/stack/nova/nova/virt/xenapi/driver.py", line 798, in _unwrap_plugin_exceptions
    return func(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/XenAPI.py", line 229, in __call__
    return self.__send(self.__name, args)
  File "/usr/local/lib/python2.7/dist-packages/XenAPI.py", line 133, in xenapi_request
    result = _parse_result(getattr(self, methodname)(*full_params))
  File "/usr/local/lib/python2.7/dist-packages/XenAPI.py", line 203, in _parse_result
    raise Failure(result['ErrorDescription'])
Failure: ['XENAPI_PLUGIN_FAILURE', 'upload_vhd', 'TypeError', "make_subprocess() got an unexpected keyword argument 'env'"]

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/43580

[Mate Lakat (mate-lakat)]

This bug was caused by this commit:

  https://review.openstack.org/#/c/31898/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/43580
Committed: http://github.com/openstack/nova/commit/36be3145c76d185ecabac20c4df145b7f46f67b1
Submitter: Jenkins
Branch: master

commit 36be3145c76d185ecabac20c4df145b7f46f67b1
Author: Mate Lakat <email address hidden>
Date: Sat Aug 24 10:51:09 2013 +0100

    Add env to make_subprocess

    Due to a previous commit, a client of make_subprocess is making a call
    with an env parameter. As make_subprocess does not have such a
    parameter, image upload fails. This patch adds the env keyword argument
    to make_subprocess, and use that in the Popen call.

    Fixes bug 1216267

    Change-Id: I8098b484067b54c15fe95f2bf84c5890db7ebcb3