click-scope calls download-manager once per result
Bug #1215904 reported by
Alejandro J. Cura
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-download-manager |
Fix Released
|
High
|
Manuel de la Peña | ||
ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
unity-scope-click (Ubuntu) |
Invalid
|
Medium
|
Alejandro J. Cura |
Bug Description
Click scope is calling download-manager to get the DBus ObjectPaths of each app, whether they are downloading or not, and this is slow.
To fix this, we need to change the API of download manager so the DBus ObjectPaths for the downloads can be automatically inferred from some part of the metadata.
Related branches
lp:~mandel/ubuntu-download-manager/allow-client-object-path
- Diego Sarmentero (community): Approve
- Alejandro J. Cura (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 372 lines (+218/-13)7 files modifiedlibubuntudownloadmanager/apparmor.cpp (+21/-10)
libubuntudownloadmanager/apparmor.h (+1/-0)
libubuntudownloadmanager/download_factory.cpp (+23/-3)
ubuntu-download-manager-tests/fake_apparmor.cpp (+19/-0)
ubuntu-download-manager-tests/fake_apparmor.h (+1/-0)
ubuntu-download-manager-tests/test_download_factory.cpp (+146/-0)
ubuntu-download-manager-tests/test_download_factory.h (+7/-0)
Changed in unity-scope-click: | |
status: | New → Confirmed |
importance: | Undecided → High |
assignee: | nobody → Alejandro J. Cura (alecu) |
Changed in ubuntu-download-manager: | |
status: | Confirmed → In Progress |
Changed in ubuntu-download-manager: | |
milestone: | none → 0.3 |
Changed in ubuntu-download-manager: | |
status: | Fix Committed → Fix Released |
Changed in unity-scope-click: | |
importance: | High → Medium |
affects: | unity-scope-click → unity-scope-click (Ubuntu) |
tags: | added: qa-daily-testing rtm14 |
To post a comment you must log in.
Fix committed into lp:ubuntu-download-manager at revision 121, scheduled for release in ubuntu- download- manager, milestone 0.3