powervm driver is not properly cleaning up compressed images

[Matt Riedemann]

This is on the master branch (current havana trunk). Ran tempest against the powervm driver with a backing VIOS hypervisor, there are no instances left over after the tests are done (everything was successful):

http://paste.openstack.org/show/44772/

But on the backing hypervisor, there are leftover image files:

http://paste.openstack.org/show/44773/

I found that the powervm method that is supposed to remove the files isn't using the --force option with the rm command:

https://github.com/openstack/nova/blob/master/nova/virt/powervm/operator.py#L800

Also, this method isn't even used in the code:

https://github.com/openstack/nova/blob/master/nova/virt/powervm/operator.py#L785

[Matt Riedemann (mriedem)]

Marked this as high importance because over time the backing drive on the vios system fills up with images and then tempest pukes until you manually get on there and clean it up.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/43161

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/43162

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/43161
Committed: http://github.com/openstack/nova/commit/5c95824191855b0012268f641e5e738888b8d13f
Submitter: Jenkins
Branch: master

commit 5c95824191855b0012268f641e5e738888b8d13f
Author: Matt Riedemann <email address hidden>
Date: Tue Aug 20 21:14:41 2013 -0700

    powervm: actually remove files after migration

    The powervm driver is attempting to clean up compressed image gz files
    in the migration flow but the rm command being issued doesn't use the
    --force option, so the files are piling up on the backing hypervisor.

    This patch properly removes the files like in other parts of the powervm
    code (see blockdev.py for example) and fixes the tests so the
    _remove_file method is actually tested.

    Closes-Bug: #1214985

    Change-Id: I82919aa20447230e317c13f51bdf1c204a2eca39

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/43162
Committed: http://github.com/openstack/nova/commit/47fd5a85afc873433131265c75f011a9a8d971ca
Submitter: Jenkins
Branch: master

commit 47fd5a85afc873433131265c75f011a9a8d971ca
Author: Matt Riedemann <email address hidden>
Date: Tue Aug 20 21:21:37 2013 -0700

    Remove unused _decompress_image_file from powervm operator class

    While looking at bug 1214985 I noticed that the _decompress_image_file
    method in the BaseOperator class wasn't being used, so this patch simply
    cleans that up to avoid future confusion.

    Related-Bug: #1214985

    Change-Id: Ic6f2010727dcc1dfabc310ffa3bd5ca0b6799537