FC attach fails for single WWN

[Avishay Traeger]

When attaching a volume with FC, there are two options in the code for WWNs - list or string:

if isinstance(ports, list):
    for wwn in ports:
        wwns.append(wwn)
    elif isinstance(ports, str):
        wwns.append(ports)

Unfortunately when we have a single WWN, it's of type unicode and not string, and therefore 'wwns' is an empty list. This causes the attach to fail.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/42914

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/42935

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/42935
Committed: http://github.com/openstack/cinder/commit/8bd26071418c26ccaa40423b75750fa3bab1fa22
Submitter: Jenkins
Branch: master

commit 8bd26071418c26ccaa40423b75750fa3bab1fa22
Author: Avishay Traeger <email address hidden>
Date: Tue Aug 20 18:53:47 2013 +0300

    Fix Fibre Channel attach for single WWN

    The code allowed for only a string of the WWN or a list of them.
    Unfortunately unicode is also returned, for which the attach fails.
    This patch allows for unicode as well.

    Change-Id: I4d2809b41b24b2240e447a5c09f14e6438304cd6
    Fixes: bug 1214413

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/42914
Committed: http://github.com/openstack/nova/commit/52c0668548eb4a7e3536c241c9551cdf89f2d696
Submitter: Jenkins
Branch: master

commit 52c0668548eb4a7e3536c241c9551cdf89f2d696
Author: Avishay Traeger <email address hidden>
Date: Tue Aug 20 17:44:46 2013 +0300

    Fix Fibre Channel attach for single WWN

    The code allowed for only a string of the WWN or a list of them.
    Unfortunately unicode is also returned, for which the attach fails.
    This patch allows for unicode as well.

    Change-Id: I1d81abc3f8569ce8b3fb25c0e9c8aefd10e9aae8
    Fixes: bug 1214413