Cinder

flake8 H202 error in test_image_utils.py

Bug #1214365 reported by Kui Shi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Kui Shi
Cinder 2013.2 "havana"

Bug Description

"./run_tests.sh -p" get the following flake8 error:

$ ./run_tests.sh -p
Running flake8 ...
cinder/tests/test_image_utils.py:189:10: H202 assertRaises Exception too broad

Kui Shi (skuicloud)
Changed in cinder:
assignee: nobody → Kui Shi (skuicloud)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43035

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/43035
Committed: http://github.com/openstack/cinder/commit/684b3ccf77b5051d9bc15b931ea756f4639492c2
Submitter: Jenkins
Branch: master

commit 684b3ccf77b5051d9bc15b931ea756f4639492c2
Author: Kui Shi <email address hidden>
Date: Wed Aug 21 10:48:55 2013 +0800

    flake8 H202 error in test_image_utils.py

    H202 will detect following case:
    self.assertRaises(Exception, foo)

    Replace Exception with test.TestingException to pass the H202 checking.

    Bug #1214365

    Change-Id: Idbd13d11995e6a22e99bb9d63c344a5b1a75f987

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.