Cinder

logging uses a mix of 'name' and 'id'

Bug #1214140 reported by John Griffith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
John Griffith
Cinder 2013.2 "havana"

Bug Description

The logging in cinder.volume.manager has a mix of uses between identifying the volume by id and name. We should probably standardize this on id since that's what we use primarily as our unique identifier.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/42738

Changed in cinder:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/42738
Committed: http://github.com/openstack/cinder/commit/b318bd3b1cf7b6497af27ccf8d6982427240a642
Submitter: Jenkins
Branch: master

commit b318bd3b1cf7b6497af27ccf8d6982427240a642
Author: John Griffith <email address hidden>
Date: Mon Aug 19 15:04:15 2013 -0600

    Standardize on ID for log messages

    We have some places where logs use name to identify
    a volume and others where we use ID. Let's standardize
    on the UUID here as that's typically the unique identifier
    we use in most places anyway. Even though name is a
    derviative it seems better to be consistent with this
    and use the UUID by itself.

    Change-Id: Iaee3d146042780e4a526834db1e0be84a705f24b
    Fixes: bug 1214140

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.