add foreign keys to oauth tables

Bug #1214135 reported by Steve Martinelli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
yong sheng gong

Bug Description

As suggested by Adam, the consumer_id should be a foreign key in the RequestToken and AccessToken tables, since it exists in the ConsumerTable.
https://review.openstack.org/#/c/29130/64/keystone/contrib/oauth1/migrate_repo/versions/001_add_oauth_tables.py

If these changes were to be implemented, then 'delete_consumer' would also need a slight change too.
https://review.openstack.org/#/c/29130/64/keystone/contrib/oauth1/backends/sql.py

Changed in keystone:
assignee: nobody → yong sheng gong (gongysh)
Dolph Mathews (dolph)
Changed in keystone:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43237

Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/43237
Committed: http://github.com/openstack/keystone/commit/be6e8ec1653f8a1136a41736e0c6696eeaf914ba
Submitter: Jenkins
Branch: master

commit be6e8ec1653f8a1136a41736e0c6696eeaf914ba
Author: Yong Sheng Gong <email address hidden>
Date: Thu Aug 22 10:45:11 2013 +0800

    add foreign key constraint on oauth tables

    Change-Id: Id62bd77950681db0303f6b3bc1a630aa59dd40c1
    Fixes: Bug #1214135

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.