Mahara

Undefined variable $id in group/report.php

Bug #1213908 reported by Howard Miller
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Aaron Wells
Mahara 1.8.0
1.6
Fix Released
Low
Unassigned
Mahara 1.6.7
1.7
Fix Released
Low
Unassigned
Mahara 1.7.3

Bug Description

In version 1.6.testing (latest from Git at time of writing) there is an undefined variable in file group/report.php at line 55. The line is...

$sharedviews[$id]['groupname'] = get_field('group', 'name', 'id', $data['group']);

However, the variable $id is clearly not defined anywhere before this line.

Revision history for this message
Howard Miller (howardsmiller) wrote :

Just checked and it still appears to be the same in the latest 1.7.testing too

Revision history for this message
Howard Miller (howardsmiller) wrote :

...and master :)

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Thanks for the bug report! I've submitted a patch for it: https://reviews.mahara.org/#/c/2430/

Changed in mahara:
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Aaron Wells (u-aaronw)
milestone: none → 1.8.0rc1
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2430
Committed: http://gitorious.org/mahara/mahara/commit/67f3a963abc382f74bd292cea0c02031b9bf8b72
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 67f3a963abc382f74bd292cea0c02031b9bf8b72
Author: Aaron Wells <email address hidden>
Date: Thu Aug 22 20:27:02 2013 +1200

Fix display of the name of the sharing group on the Group Participation report

Bug #1213908: If a group shares a page with another group, and that other group
has "Participation report" turned on, and an admin views that participation report,
it was failing to properly show the name of the first group that was sharing
that page.

Change-Id: Id4d2b7c7bf3616233091f828f39ff040ebab64bd

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2441
Committed: http://gitorious.org/mahara/mahara/commit/8a3b288eb16c59573e87e8272e236e9a7d3941da
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.7_STABLE

commit 8a3b288eb16c59573e87e8272e236e9a7d3941da
Author: Aaron Wells <email address hidden>
Date: Thu Aug 22 20:27:02 2013 +1200

Fix display of the name of the sharing group on the Group Participation report

Bug #1213908: If a group shares a page with another group, and that other group
has "Participation report" turned on, and an admin views that participation report,
it was failing to properly show the name of the first group that was sharing
that page.

Change-Id: Id4d2b7c7bf3616233091f828f39ff040ebab64bd

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2442
Committed: http://gitorious.org/mahara/mahara/commit/7740d66bd13d49e2cd1e3f637843c6a37098ae52
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.6_STABLE

commit 7740d66bd13d49e2cd1e3f637843c6a37098ae52
Author: Aaron Wells <email address hidden>
Date: Thu Aug 22 20:27:02 2013 +1200

Fix display of the name of the sharing group on the Group Participation report

Bug #1213908: If a group shares a page with another group, and that other group
has "Participation report" turned on, and an admin views that participation report,
it was failing to properly show the name of the first group that was sharing
that page.

Change-Id: Id4d2b7c7bf3616233091f828f39ff040ebab64bd

Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.8rc1 → 1.8.0
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.