driver call to accept_transfer doesn't have enough info

Bug #1213275 reported by John Griffith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
John Griffith

Bug Description

The driver call portion of accept_transfer only includes the previous/pending owner and the volume-ref, this means that for backends that may need to do things like transfer accounts there's not enough information given to do so.

We need to either add the new user/project id info to the call or change things around in the reference update passed in to the drivers.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/42443

Changed in cinder:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/42443
Committed: http://github.com/openstack/cinder/commit/8fa1fa806b36bd9a06c13b0d1255e87c6307b179
Submitter: Jenkins
Branch: master

commit 8fa1fa806b36bd9a06c13b0d1255e87c6307b179
Author: John Griffith <email address hidden>
Date: Fri Aug 16 17:12:11 2013 -0600

    Added need info to accept_transfer

    Drivers that implement accept_transfer will need
    things like the new user_id and project_id. We were
    not including this in the original add, in order for
    drivers that are tenant aware this information will be
    necessary.

    Also the get_volume call in the transfer was using
    the new user context, so the volume would never be
    found. We fix this here by providing an elevated
    context to the get_volume call when accepting the
    transfer.

    Change-Id: I7b60c19950f85c4309a97bb842ff238bcf8e746a
    Fixes: bug 1213275

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.