Cisco plugin deps should be in quantum

[Ian Wells]

There are core.pp entries to bring in Cisco plugin dependencies. They're in the wrong place and they also don't have dependencies on the programs that use them; move them into the Cisco plugin code and fix the dependencies.

[Mark T. Voelker (mvoelker)]

Could you actually explain what dependencies you're concerned with?

[Ian Wells (ijw-ubuntu)]

Things I would expect to be in the Nexus plugin module and not in core.pp:

package { 'python-ncclient':
      ensure => installed,
} ~> Service['quantum-server']
(that dependency wasn't there when I filed the bug, and ought to be a -> in any case; also use a 'before' or 'notify' or you risk hitting a puppet bug in 2.7 that's triggered by mixing -> and the other sort of dependency)

    # hack to make sure the directory is created
    Quantum_plugin_cisco<||> ->
    file {'/etc/quantum/plugins/cisco/nexus.ini':
      owner => 'root',
      group => 'root',
      content => template('nexus.ini.erb')
    } ~> Service['quantum-server']
Should be -> I would think; absolutely shouldn't be here

  if $nexus_credentials {
    file {'/var/lib/quantum/.ssh':
      ensure => directory,
      owner => 'quantum',
      require => Package['quantum-server']
    } ->
    nexus_creds{ $nexus_credentials: }

Shouldn't be here

[Michael Chapman (michaeltchapman)]

~> will cause the service to restart if the resource is set, which will result in the right things happening afaict.

I am probably not going to move this to puppet-quantum for grizzly and will instead do it for havana, since the config files are going to change and due to puppet-inifile not supporting nesting as far as I can tell, it's going to be a bit of work to do right and get into upstream puppet-quantum using the same style for config as everything else. I could move the nexus code to another module without an upstream such as puppet-coi, which would be easier.

[Michael Chapman (michaeltchapman)]

https://github.com/CiscoSystems/puppet-coe/pull/16
https://github.com/CiscoSystems/grizzly-manifests/pull/165

Moves nexus plugin to puppet-coe