Reviews from python-neutronclient are shown in neutron

Bug #1212647 reported by Ilya Shakhat
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Stackalytics
Fix Released
Critical
Ilya Shakhat

Bug Description

subj

Ilya Shakhat (shakhat)
Changed in stackalytics:
milestone: none → 0.2
assignee: nobody → Ilya Shakhat (shakhat)
importance: Undecided → High
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stackalytics (master)

Fix proposed to branch: master
Review: https://review.openstack.org/42110

Changed in stackalytics:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stackalytics (master)

Reviewed: https://review.openstack.org/42110
Committed: http://github.com/stackforge/stackalytics/commit/8200a799ae3acb345448839932ee91eebdca4d9d
Submitter: Jenkins
Branch: master

commit 8200a799ae3acb345448839932ee91eebdca4d9d
Author: Ilya Shakhat <email address hidden>
Date: Thu Aug 15 15:47:15 2013 +0400

    Fixed project attribute in gerrit command

    Closes bug 1212647

    Change-Id: Ia48e15e628d49a3d655402ef0eeb0dccf23fd3f3

Changed in stackalytics:
status: In Progress → Fix Committed
Revision history for this message
Ilya Shakhat (shakhat) wrote :

Re-opening the issue. With the fix gerrit doesn't return all records

Changed in stackalytics:
status: Fix Committed → In Progress
importance: High → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/42334
Committed: http://github.com/stackforge/stackalytics/commit/7a3c6a7d82084242e3a6e3f3a0c62e2eb167e6dd
Submitter: Jenkins
Branch: master

commit 7a3c6a7d82084242e3a6e3f3a0c62e2eb167e6dd
Author: Ilya Shakhat <email address hidden>
Date: Fri Aug 16 16:40:24 2013 +0400

    Revert gerrit command and set module from project attribute

    Query with project parameter returns only open reviews. There is no way
    to tell it to return closed.
    Module is set based on project attribute, however this restricts that
    module parameter in repo definition is part of repo uri.

    Closes bug 1212647

    Change-Id: I7b23711ccaf83554a40e499e0cda81cb461d6f36

Changed in stackalytics:
status: In Progress → Fix Committed
Revision history for this message
Ilya Shakhat (shakhat) wrote :

Further investigation shows that if the query matches project name by regex then it returns open reviews only, but if the exact name is given, them all records are returned.
Compare:
https://review.openstack.org/#/q/project:%255E.*/stackalytics,n,z -- just open reviews
vs
https://review.openstack.org/#/q/project:stackforge/stackalytics,n,z -- all reviews

Reopening the issue

Changed in stackalytics:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stackalytics (master)

Fix proposed to branch: master
Review: https://review.openstack.org/42360

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stackalytics (master)

Reviewed: https://review.openstack.org/42360
Committed: http://github.com/stackforge/stackalytics/commit/d09305d4903ecde5244c530991f0d57a434a39b3
Submitter: Jenkins
Branch: master

commit d09305d4903ecde5244c530991f0d57a434a39b3
Author: Ilya Shakhat <email address hidden>
Date: Fri Aug 16 18:24:35 2013 +0400

    Fixed gerrit command to retrieve projects by exact match

    Closes bug 1212647

    Change-Id: I50864fcfa111fa7e8c6cc200f540f58880c25f96

Changed in stackalytics:
status: In Progress → Fix Committed
Ilya Shakhat (shakhat)
Changed in stackalytics:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.