cmd/juju: debug-log should not take additional arguments

[Dave Cheney]

If you mistakenly type "juju debug-log $UNIT" instead of "juju debug-hooks $UNIT" you'll get a confusing error.

lucky(~/charms/precise/mediawiki) % juju debug-log juju-gui/0
Warning: Permanently added '15.185.243.11' (ECDSA) to the list of known hosts.
bash: juju-gui/0: No such file or directory
Connection to 15.185.243.11 closed.
error: exit status 127

This may be related to debug-log being too close a cousin of ssh.

lucky(~/charms/precise/mediawiki) % juju help debug-log
usage: juju debug-log [options] [<ssh args>...]
purpose: display the consolidated log file

options:
-e, --environment (= "nec-az3")
    juju environment to operate in

Launch an ssh shell on the state server machine and tail the consolidated log file.
The consolidated log file contains log messages from all nodes in the environment.

[John A Meinel (jameinel)]

Yeah, I think parameters accidentally get auto-passed through to the 'ssh' subprocess, which doesn't really fit with how we want to use debug-log.

I think what we'll want to have is 'debug-log' to filter based on a unit passed in, so we should at least refuse the extra arguments until we have the functionality.

[Dave Cheney (dave-cheney)]

jam: SGTM.

On Sat, Aug 17, 2013 at 4:09 PM, John A Meinel <email address hidden>wrote:

> Yeah, I think parameters accidentally get auto-passed through to the
> 'ssh' subprocess, which doesn't really fit with how we want to use
> debug-log.
>
> I think what we'll want to have is 'debug-log' to filter based on a unit
> passed in, so we should at least refuse the extra arguments until we
> have the functionality.
>
>
> ** Changed in: juju-core
> Importance: Undecided => High
>
> ** Changed in: juju-core
> Status: New => Triaged
>
> ** Tags added: ui
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1212542
>
> Title:
> cmd/juju: debug-log should not take additional arguments
>
> Status in juju-core:
> Triaged
>
> Bug description:
> If you mistakenly type "juju debug-log $UNIT" instead of "juju debug-
> hooks $UNIT" you'll get a confusing error.
>
> lucky(~/charms/precise/mediawiki) % juju debug-log juju-gui/0
> Warning: Permanently added '15.185.243.11' (ECDSA) to the list of known
> hosts.
> bash: juju-gui/0: No such file or directory
> Connection to 15.185.243.11 closed.
> error: exit status 127
>
> This may be related to debug-log being too close a cousin of ssh.
>
> lucky(~/charms/precise/mediawiki) % juju help debug-log
> usage: juju debug-log [options] [<ssh args>...]
> purpose: display the consolidated log file
>
> options:
> -e, --environment (= "nec-az3")
> juju environment to operate in
>
> Launch an ssh shell on the state server machine and tail the
> consolidated log file.
> The consolidated log file contains log messages from all nodes in the
> environment.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju-core/+bug/1212542/+subscriptions
>

[William Reade (fwereade)]

Frank, please ensure that your reworked debug-log handles extra args sensibly.