Ability to Upgrade / Update Guest Not Fully Functional

[Auston McReynolds]

trove-mgmt-cli's "host > update_all" seems to claim to be able to upgrade/update the guest on deployed hosts, but it does not work as advertised.

I see https://github.com/openstack/python-troveclient/blob/b98893926d14bd0b5b2706c808688659695c1731/troveclient/hosts.py#L49-L54

however, I can't find a corresponding "update" action in the mgmt api:

https://github.com/openstack/trove/blob/166fd33ee013488bca13507fba03da73697f0199/trove/extensions/mgmt/instances/service.py#L97

There's no mention in the apischema of an update/upgrade action, so I'm thinking that this feature wasn't fully ported. On a semi-related note, trove-mgmt-cli's "host > list" exposes this fault: https://bugs.launchpad.net/trove/+bug/1130983. The gerrit review for the proposed fix (https://review.openstack.org/#/c/32916/) had this comment added before the commit was ultimately abandoned:

> ""rdhosts" is a Rackspace Nova API extension. IIRC Mike put those in the
> public at some point as a fork, although we need to
> probably find a better way to handle them.
>
> We *should* change things to work with standard Nova functionality, but
> this function has been changed so that its return values > are entirely
> different. This will break expectations of Rackspace ops (as well as tests)
> are relying on. I think a better solution is to > "fix" this in a way that
> doesn't mean radically changing the views, or simply creating a new API
> call entirely."

[Michael Basnight (hubcap)]

Id rather fix the existing api calls if possible.

[Nikhil Manchanda (slicknik)]

Dan, are we planning to fix this old mgmt API as part of the Upgrade BP work that you are doing? Thanks!

[Dan Nguyen (daniel-a-nguyen)]

yep, let me add this to the current patch in review

[Dan Nguyen (daniel-a-nguyen)]

https://review.openstack.org/#/c/81410/12/trove/guestagent/api.py

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/81410
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=ac45127c86e5b9d4723b0cb8a58a8b5d1570c706
Submitter: Jenkins
Branch: master

commit ac45127c86e5b9d4723b0cb8a58a8b5d1570c706
Author: daniel-a-nguyen <email address hidden>
Date: Fri Mar 28 15:49:57 2014 -0700

    Added route for Admin API to support guest upgrade

    Added optional metadata param to API

    1. Changed route to {tenant_id}/mgmt/instances/{instance_id}/upgrade
    2. Changed POST body to send properties inside an upgrade dict
    3. Removed unimplemented method from guest agent manager
    4. Swap out rpc call to use _cast
    5. Removed instance_id from rpc call
    6. Removed strategy from api calls
    7. Switched out import of guestagent api in favor of common.remote
    8. Rename UpgradeNotifier to UpgradeMessageSender

    Change-Id: I12d09fd70ab028da1cd2818fe380310e99b66d2d
    Implements: blueprint upgrade-guestagent
    Closes-Bug: #1211924