create volume clone from volume broken in cinder

[Edward Hope-Morley]

creating a volume as a clone of another volume e.g. 'cinder create --source-volid <vol-id> <size>' does not create a clone but instead just creates a new empty volume. This issue appears to have been introduced since the Cinder TaskFlow merge and is a result of taskflow doing a '_create_raw_volume' instead of '_create_from_source_volume'.

[Swapnil Kulkarni (coolsvap-deactivatedaccount)]

Edward, I can see types are specified in the function mapping. Depending on the type specified, the method will be called. Can you update the driver you are using and logs for the bug you have observed?

[Edward Hope-Morley (hopem)]

Hi Swapnil,

It does not appear to matter which driver you use. I have tried RBD and LVM. It looks like the scheduler is not getting passed the source_volid so it never gets to the volume driver. I am tracing throught it now so will attempt to propose a fix. I'll mark this bug as in progress for now.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/41738

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/41738
Committed: http://github.com/openstack/cinder/commit/baddafc5e5413feeddc20b73d30bb7c169342673
Submitter: Jenkins
Branch: master

commit baddafc5e5413feeddc20b73d30bb7c169342673
Author: Edward Hope-Morley <email address hidden>
Date: Tue Aug 13 18:09:45 2013 +0100

    Fixes volume clone from volume

    Cloning a volume from another volume appeared
    to have been broken by new create_volume
    taskflow. Clone from snapshot was not affected.

    Also added a unit test this scenario.

    Change-Id: I4f174e1616f6944cce64f8d522fa42a9f00f55eb
    Fixes: bug #1211709