"Direct" vs. "direct" in impl_qpid

[David Ripton]

impl_qpid.py has {"type": "Direct"} (with a capital D) in one place. "direct" (lowercase) in others. It appears that qpid is case-sensitive about exchange types, so the version with the capital D is invalid. This ends up causing qpid to throw an error like:

>> "/usr/lib/python2.6/site-packages/qpid/messaging/endpoints.py",
>> line 567, in _ewait\n self.check_error()\n', ' File
>> "/usr/lib/python2.6/site-packages/qpid/messaging/endpoints.py",
>> line 556, in check_error\n raise self.error\n', 'NotFound:
>> not-found: Exchange type not implemented: Direct
>> (qpid/broker/SessionAdapter.cpp:117)(404)\n']

It should be a one-character fix.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/41427

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/41427
Committed: http://github.com/openstack/oslo-incubator/commit/bec54ac5fb6a190c98079537f63d2f0e17584d21
Submitter: Jenkins
Branch: master

commit bec54ac5fb6a190c98079537f63d2f0e17584d21
Author: David Ripton <email address hidden>
Date: Mon Aug 12 10:09:20 2013 -0400

    Fix case error in qpid exchange type "direct"

    Most places correctly have "direct", but one place has "Direct"
    instead, which is incorrect.

    Fixes bug #1211338

    Change-Id: I2516317ff7f6ff18ee0a99a60d0c058ed309d4da

[David Ripton (dripton)]

The fix is in oslo-incubator but needs to be merged to projects that use it. I see impl_qpid.py in neutron, nova, cinder, heat, and ceilometer. There's already a nova review to update the rpc code from oslo. For the other projects, I may need to initiate merge reviews.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/44924

[Russell Bryant (russellb)]

nova grizzly patch: https://review.openstack.org/#/c/61831/

[Eric Harney (eharney)]

Fixed in Cinder master (in 2013.2): https://review.openstack.org/#/c/44532/

[Eric Harney (eharney)]

Cinder grizzly patch: https://review.openstack.org/#/c/62426/

[Assaf Muller (amuller)]

Neutron master (Merged): https://review.openstack.org/#/c/42358/
Neutron stable/grizzly (In review): https://review.openstack.org/#/c/62663/
* stable/havana already has it

[Assaf Muller (amuller)]

Merged to Havana stable, Grizzly stable, master.