There are several problems of exposing resource status in NEC Plugin; 1) a status in response body is not updated in the operation, and 2) the plugin might overwrite ERROR status to ACTIVE or DOWN without any operations to the backend (OFC) which make the plugin expose wrong status.
We have to make sure that the plugin exposes right status in response body, and does not overwrite ERROR status until another operation to the backend has succeeded.
I confirmed the following symptoms, so we also need unit tests to verify that these are fixed:
1-a) While creating a network and operation to the backend has failed, the plugin returns status='ACTIVE' in the response body. It must be 'ERROR'.
1-b) When updating a network from admin_state_up=False to admin_state_up=True, the plugin returns status='DOWN' in a response body. However, the status is already updated to 'ACTIVE' in the DB, so I can get status='ACTIVE' after this activation.
1-c) When creating a port, the plugin always returns status='ACTIVE' in a response body even though status='DOWN'.
1-d) When updating a port from admin_state_up=False to admin_state_up=True and the creation of port on the backend has failed, the plugin returns status='DOWN' in a response body although the status is already updated to 'ERROR' in the DB.
2-a) When updating a port with admin_state_up=False after 1-d), the plugin overwrite its status to 'DOWN' without operations to the backend.
Fix proposed to branch: master
Review: https:/