incorrect bootable flag for volume cloned from image

[Xiaoxi Chen]

Reopen bug 1185533 (https://bugs.launchpad.net/cinder/+bug/1185533)

Not sure who breaks this again, if create a volume from image by the cloning way( i.e via the driver.clone_image method), the volume will not be marked as bootable.

Edward Hope-Morley reported this bug and fixed it several month before, but he failed to give a unit test together with the patch, not sure who breaks this again during refactor.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/41382

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/41382
Committed: http://github.com/openstack/cinder/commit/162aa28824fb6caa6e3adaf7ed268e9fae178a73
Submitter: Jenkins
Branch: master

commit 162aa28824fb6caa6e3adaf7ed268e9fae178a73
Author: xiaoxi_chen <email address hidden>
Date: Mon Aug 12 19:25:59 2013 +0800

    Set bootable flag for volume cloned from image

    In previous code we don't set the bootable flag for volume
    cloned from image. This does not appear to break booting
    from volume at present but the status displayed by the cinder
    client is broken.

    The bug is reported and fixed several months ago(bug #1185533)
    but the author doesn't provide unit test with the patch. Now it
    has been broken again by somebody else.The patch re-fixed this
    bug together with unit tests.

    Also add a function named _handle_bootable_volume_glance_meta,
    it is a combination of enable_bootable_flag and glance_metadata
    handling. There are 3 kinds of volume creation tasks may required
    to copy/fetch the glance metadata. In previous code every kind of
    task have its own handling code, this patch consolidate them together
    to share some common code.

    fixed bug #1211272
    fixed bug #1185533

    Change-Id: I86007e26efbebe58dc0c5995b6f14f68258144b5