Nicira plugin: remove_router_interface fail with HTTP 404

[Masashi Teruya]

{path-to-neutron}/plugins/nicira/NeutronPlugin.py: remove_router_interface always fail with HTTP 404.

I found remove_router_interface sends following http request twice.
The 1st response is OK (successfully removed) so the other one throws 404 error.
/ws.v1/lrouter/{router_id}/lport/{switch_id}

There are 2 methods related to this operation.
1819: super(NvpPluginV2, self).remove_router_interface(context, router_id, interface_info)
1851: nvplib.delete_router_lport(self.cluster, router_id, lrouter_port_id)

[ Workaround ]
When I comment out 1851, the method doesn't throw 404 error any more.

[Salvatore Orlando (salvatore-orlando)]

Hi Masashi,

I was going to report exactly the same bug and found yours!
this happened with a recent commit - the fix will come soon (matter of minutes)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/41700

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/41700
Committed: http://github.com/openstack/neutron/commit/d97b56086c0442c58b02c58afb9dd0ed32d6f748
Submitter: Jenkins
Branch: master

commit d97b56086c0442c58b02c58afb9dd0ed32d6f748
Author: Salvatore Orlando <email address hidden>
Date: Tue Aug 13 07:08:27 2013 -0700

    Do not call remove_router_lport in remove_router_interface

    Bug 1211149

    The call will cause a failure as the router port is already removed
    by _nvp_delete_router_port.
    This patch also add the support on the fake nvp api client to verify
    this kind of condition.

    Change-Id: Ieb5ca5c239ccc993b96dd5bad0b412211b45417e