vendor_data blueprint causes ValueError

[Davanum Srinivas (DIMS)]

When testing support for config drive with vmware, we came across this bug (see comments in https://review.openstack.org/#/c/40029/) This bug was introduced by code in the following review - https://review.openstack.org/#/c/37964/14

    2013-08-10 11:13:06.190 ERROR nova.virt.vmwareapi.vmops [req-fd4731e0-9c27-49f0-8c8c-ab577e032063 demo demo] [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] Creating config drive failed with error: '2012-08-10' is not in list
    2013-08-10 11:13:06.192 ERROR nova.compute.manager [req-fd4731e0-9c27-49f0-8c8c-ab577e032063 demo demo] [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] Instance failed to spawn
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] Traceback (most recent call last):
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] File "/opt/stack/nova/nova/compute/manager.py", line 1353, in _spawn
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] block_device_info)
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] File "/opt/stack/nova/nova/virt/vmwareapi/driver.py", line 203, in spawn
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] admin_password, network_info, block_device_info)
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] File "/opt/stack/nova/nova/virt/vmwareapi/vmops.py", line 427, in spawn
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] cookies)
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] File "/opt/stack/nova/nova/virt/vmwareapi/vmops.py", line 490, in _create_config_drive
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] e, instance=instance)
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] File "/opt/stack/nova/nova/virt/vmwareapi/vmops.py", line 471, in _create_config_drive
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] with configdrive.ConfigDriveBuilder(instance_md=inst_md) as cdb:
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] File "/opt/stack/nova/nova/virt/configdrive.py", line 75, in __init__
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] self.add_instance_metadata(instance_md)
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] File "/opt/stack/nova/nova/virt/configdrive.py", line 96, in add_instance_metadata
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] for (path, value) in instance_md.metadata_for_config_drive():
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] File "/opt/stack/nova/nova/api/metadata/base.py", line 426, in metadata_for_config_drive
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] if self._check_version(HAVANA, version):
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] File "/opt/stack/nova/nova/api/metadata/base.py", line 344, in _check_version
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] return versions.index(requested) >= versions.index(required)
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] ValueError: '2012-08-10' is not in list
    2013-08-10 11:13:06.192 TRACE nova.compute.manager [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24]
    2013-08-10 11:13:06.226 DEBUG nova.compute.claims [req-fd4731e0-9c27-49f0-8c8c-ab577e032063 demo demo] [instance: 523d647a-f8c3-4578-84a2-44bd361dbd24] Aborting claim: [Claim: 512 MB memo

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/41324

[Scott Moser (smoser)]

thank you.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/41324
Committed: http://github.com/openstack/nova/commit/64fe85d526c7a8f88193b41edd4067a6d44c0dc0
Submitter: Jenkins
Branch: master

commit 64fe85d526c7a8f88193b41edd4067a6d44c0dc0
Author: Davanum Srinivas <email address hidden>
Date: Sun Aug 11 21:41:58 2013 -0400

    Fix bad check for openstack versions (vendor_data/config drive)

    Looks like the lack of a test case sneaked in this bug. Added a
    simple one that just ensures that we can get a list of all the
    metadata information. Basic issue was that the check_version
    was checking against ec2 versions. Changed it to check OpenStack
    version including the 'latest'.

    Fixes bug #1211122

    Change-Id: Ifac7659467b81abcffd3f84a24292c11f2e058fc