Use content from another text box not displaying 'copy' message

Bug #1211088 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon

Bug Description

Version mahara 1.8

Problem:
The 'If you edit the text of this block, it will also be changed in 1 other block(s) where it appears. Make a copy' message is not displayed anymore if you choose to use content from another text box and have license metadata turned off in the config.

The javascript was expecting to find certain license elements and update their css - but they did not exist in this scenario.

Solution:
I've added a sanity check to only try and update them if the first license element exists.

I've also altered the layout of the instance edit display so that things make more sense - eg keep the choosing of another text box functionality to appear directly below the wysiwyg editor (as it did in previous mahara version)

Revision history for this message
Robert Lyon (robertl-9) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2398
Committed: http://gitorious.org/mahara/mahara/commit/b5c347a4bb77b9d17a7eb8b5add783fe71a55e43
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit b5c347a4bb77b9d17a7eb8b5add783fe71a55e43
Author: Robert Lyon <email address hidden>
Date: Mon Aug 12 10:42:03 2013 +1200

JS issue when license metadata was not enabled (Bug #1211088)

Also fixed up the layout of the edit form to make more sense
by grouping the choosing of existing textbox to be next to the
wysiwyg editor rather than the bottom of the form.

Change-Id: Ic31bff4f4c2cb59bd5fa789421298debd293b8a7
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.8rc1 → 1.8.0
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.