unused abstract class definitions in storage driver tests

Bug #1210281 reported by Terri Yu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
Terri Yu

Bug Description

DBTestBase and EventTestBase are defined as abstract classes in tests/storage/base.py

However, neither of these classes has defined any abstract methods, so the abstract class definitions are unnecessary.

Terri Yu (terriyu)
Changed in ceilometer:
assignee: nobody → Terri Yu (terriyu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/41000

Changed in ceilometer:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/41000
Committed: http://github.com/openstack/ceilometer/commit/51cd25c6b241b308d5cf840c1221f8f0d5b2ce54
Submitter: Jenkins
Branch: master

commit 51cd25c6b241b308d5cf840c1221f8f0d5b2ce54
Author: Terri Yu <email address hidden>
Date: Fri Aug 9 01:00:20 2013 +0000

    Remove unused abstract class definitions

    Fixes bug #1210281

    Removed abstract classes definitions from DBTestBase and EventTestBase classes
    in storage driver tests since they are not used. Neither of these classes has
    defined any abstract methods, so the abstract class definitions are unnecessary.

    Also removed import statement for abstract base classes since there are now no
    abstract class definitions.

    Change-Id: I0b5b487631d780ba2ab087dce2ef340f126f8a69

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.