New revisions are missing, proof does show the error

[Curtis Hovey]

http://manage.jujucharms.com/~pavel-pachkovskij/precise/rack had a history of errors in the charm that prevented the store and charmworld from seeing the new revisions.

Kapil identified this error that was not reported by proof:
    config: options.deploy_key.default: unexpected value <nil>

The author could have resolved this issue with an hour if proof had reported the issue.

[Aaron Bentley (abentley)]

This is a charm store issue, not a charmworld issue. We have been waiting for the charm store to update to tip, and so far it hasn't.

I don't think that the charm store cares about the contents of README files, but I could be wrong.

It appears that pavel pushed a new branch over top of the original branch, e.g. with push --overwrite. The evidence is:
1. <email address hidden> is not an ancestor of the current tip
2. The commit message in the branch is "rack charm v2"
3. The old revision is in the repository of the Launchpad branch.

I think it is more likely that the store expects new revisions to be descendants of the revisions that were there previously. But Kapil says "its doing a fresh checkout every time", so it's not clear whether this is the actual cause.

[Curtis Hovey (sinzui)]

It might be possible to construct a branch that satisfies the Juju store's knowledge of the revision history.

In the same rack repo as broken-trunk:
bzr branch lp:~charmers/charms/precise/rack/trunk new-trunk
cd charmers trunk
bzr pull -r <email address hidden>
bzr merge broken-trunk
^ If bzr refuses to do this, then copy all the files from broken-trunk to new-trunk
bzr ci -m "Reconstructed branch"
cd ../
bzr push lp:~pavel-pachkovskij/charms/precise/rack/trunk

Once we have verified the store sees the new revisions, the new-trunk branch can be renamed to trunk and the broken branch deleted.

[Pavel Pachkovskij (pavel-pachkovskij)]

I restored revisions order and now there is a README on http://manage.jujucharms.com/~pavel-pachkovskij/precise/rack page. But it's outdated. I suppose there's an error parsing new README.

[Curtis Hovey (sinzui)]

Hi Pavel. I will look in the logs for issues. Did you follow the steps I speculated would correct the order? I want to document this in case it happens again. This missing revision case was hypothetical to us until it happened to you. While we built the process to survive a missing revision, it would be very nice to know how to fix the data issue.

[Pavel Pachkovskij (pavel-pachkovskij)]

I pulled original branch, copied there changes from my branch and pushed to my branch on launchpad.

[Curtis Hovey (sinzui)]

README.md looks fine. There are no errors in the logs. I can see that the staging server has all 10 branch revisions and tip has the new README.md. However, the Juju store does not see any new revisions.
    https://store.juju.ubuntu.com/charm-info?charms=cs:~pavel-pachkovskij/precise/rack&stats=0
shows it sees revision 4, so manage.jujucharms.com found rev 4 and shows it.

I am told that the Juju store always does a new checkout to find the charm versions in a branch. I speculate that this might not be the case. When I tried to pull your branch into my copy, bzr errored because the branches had diverged. I had to force and overwrite. I will looks for someone with access to the Juju store to look for an error.

[Kapil Thangavelu (hazmat)]

The store goes by revid detection, it doesn't care about revnos. This does
appear to trigger a bug in the store code which needs addressing regardless
of a rename workaround.

On Thu, Aug 15, 2013 at 9:21 AM, Curtis Hovey <email address hidden> wrote:

> ** Description changed:
>
> - I suspect there is an ingest issue when a file contains unicode. This
> - issue might be a juju store problem involving a missing revision.
> + This issue might be a juju store problem involving a missing revision.
>
> cs v5, lp r5, of http://manage.jujucharms.com/~pavel-
> pachkovskij/precise/rack is not showing README.md. I found a unicode
> apostrophe in the file and advised pavel to remove it. We are now
> waiting for manage.jujucharms.com to show README.md. I know ingest as
> seen lp r7 which has the fix, but the store does not see v5 yet.
>
> The store sees
> {
> - "cs:~pavel-pachkovskij/precise/rack":{
> - "revision":4,
> -
> "sha256":"3c1f949054da15ea183ee87d974a9db50e98caf5e6abd31b666ca65a194d2c37",
> -
> "digest":"<email address hidden>"
> - }
> + "cs:~pavel-pachkovskij/precise/rack":{
> + "revision":4,
> +
> "sha256":"3c1f949054da15ea183ee87d974a9db50e98caf5e6abd31b666ca65a194d2c37",
> +
> "digest":"<email address hidden>
> "
> + }
> }
>
> I do not see this revision in the branch. staging's app.log shows
> - Revision
> <email address hidden> not found
> + Revision
> <email address hidden> not found
>
> While writing this pavel pushed a new branch with a single revision.
>
> Maybe The store finds this unacceptable and will not accept a historical
> revisions. It ignores the new data, so charmworld does the same. If this
> is the case, I think a new charm name is needed.
>
> --
> You received this bug notification because you are a member of
> Charmworld Developers, which is subscribed to charmworld.
> https://bugs.launchpad.net/bugs/1209321
>
> Title:
> New revisions are missing
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/charmworld/+bug/1209321/+subscriptions
>

[Kapil Thangavelu (hazmat)]

one tool that might give some feedback is publishing this via the juju-core
cli

ie.
cd ~/charms/precise/rack
juju publish cs:~pavel-pachkovskij/precise/rack --debug

On Thu, Aug 15, 2013 at 9:52 AM, Kapil Thangavelu <
<email address hidden>> wrote:

> The store goes by revid detection, it doesn't care about revnos. This does
> appear to trigger a bug in the store code which needs addressing regardless
> of a rename workaround.
>
>
> On Thu, Aug 15, 2013 at 9:21 AM, Curtis Hovey <email address hidden>wrote:
>
>> ** Description changed:
>>
>> - I suspect there is an ingest issue when a file contains unicode. This
>> - issue might be a juju store problem involving a missing revision.
>> + This issue might be a juju store problem involving a missing revision.
>>
>> cs v5, lp r5, of http://manage.jujucharms.com/~pavel-
>> pachkovskij/precise/rack is not showing README.md. I found a unicode
>> apostrophe in the file and advised pavel to remove it. We are now
>> waiting for manage.jujucharms.com to show README.md. I know ingest as
>> seen lp r7 which has the fix, but the store does not see v5 yet.
>>
>> The store sees
>> {
>> - "cs:~pavel-pachkovskij/precise/rack":{
>> - "revision":4,
>> -
>> "sha256":"3c1f949054da15ea183ee87d974a9db50e98caf5e6abd31b666ca65a194d2c37",
>> -
>> "digest":"<email address hidden>"
>> - }
>> + "cs:~pavel-pachkovskij/precise/rack":{
>> + "revision":4,
>> +
>> "sha256":"3c1f949054da15ea183ee87d974a9db50e98caf5e6abd31b666ca65a194d2c37",
>> +
>> "digest":"<email address hidden>
>> "
>> + }
>> }
>>
>> I do not see this revision in the branch. staging's app.log shows
>> - Revision
>> <email address hidden> not found
>> + Revision
>> <email address hidden> not found
>>
>> While writing this pavel pushed a new branch with a single revision.
>>
>> Maybe The store finds this unacceptable and will not accept a historical
>> revisions. It ignores the new data, so charmworld does the same. If this
>> is the case, I think a new charm name is needed.
>>
>> --
>> You received this bug notification because you are a member of
>> Charmworld Developers, which is subscribed to charmworld.
>> https://bugs.launchpad.net/bugs/1209321
>>
>> Title:
>> New revisions are missing
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/charmworld/+bug/1209321/+subscriptions
>>
>
>

[Kapil Thangavelu (hazmat)]

doing that shows the issue in the charm that's preventing its publishing..

juju publish cs:~hazmat/precise/rack --debug
2013-08-15 14:03:08 INFO juju publish.go:125 local digest is
<email address hidden>
2013-08-15 14:03:09 INFO juju publish.go:139 charm cs:~hazmat/precise/rack
is not yet in the store
2013-08-15 14:03:09 INFO juju publish.go:151 sending charm to the charm
store...
2013-08-15 14:03:15 INFO juju publish.go:157 charm sent; waiting for it to
be published...
2013-08-15 14:04:04 ERROR juju supercommand.go:282 command failed: charm
could not be published: config: options.deploy_key.default: unexpected
value <nil>
error: charm could not be published: config: options.deploy_key.default:
unexpected value <nil>

On Thu, Aug 15, 2013 at 10:04 AM, Kapil Thangavelu <
<email address hidden>> wrote:

> one tool that might give some feedback is publishing this via the
> juju-core cli
>
> ie.
> cd ~/charms/precise/rack
> juju publish cs:~pavel-pachkovskij/precise/rack --debug
>
>
> On Thu, Aug 15, 2013 at 9:52 AM, Kapil Thangavelu <
> <email address hidden>> wrote:
>
>> The store goes by revid detection, it doesn't care about revnos. This
>> does appear to trigger a bug in the store code which needs addressing
>> regardless of a rename workaround.
>>
>>
>> On Thu, Aug 15, 2013 at 9:21 AM, Curtis Hovey <email address hidden>wrote:
>>
>>> ** Description changed:
>>>
>>> - I suspect there is an ingest issue when a file contains unicode. This
>>> - issue might be a juju store problem involving a missing revision.
>>> + This issue might be a juju store problem involving a missing revision.
>>>
>>> cs v5, lp r5, of http://manage.jujucharms.com/~pavel-
>>> pachkovskij/precise/rack is not showing README.md. I found a unicode
>>> apostrophe in the file and advised pavel to remove it. We are now
>>> waiting for manage.jujucharms.com to show README.md. I know ingest as
>>> seen lp r7 which has the fix, but the store does not see v5 yet.
>>>
>>> The store sees
>>> {
>>> - "cs:~pavel-pachkovskij/precise/rack":{
>>> - "revision":4,
>>> -
>>> "sha256":"3c1f949054da15ea183ee87d974a9db50e98caf5e6abd31b666ca65a194d2c37",
>>> -
>>> "digest":"<email address hidden>"
>>> - }
>>> + "cs:~pavel-pachkovskij/precise/rack":{
>>> + "revision":4,
>>> +
>>> "sha256":"3c1f949054da15ea183ee87d974a9db50e98caf5e6abd31b666ca65a194d2c37",
>>> +
>>> "digest":"<email address hidden>
>>> "
>>> + }
>>> }
>>>
>>> I do not see this revision in the branch. staging's app.log shows
>>> - Revision
>>> <email address hidden> not found
>>> + Revision
>>> <email address hidden> not found
>>>
>>> While writing this pavel pushed a new branch with a single revision.
>>>
>>> Maybe The store finds this unacceptable and will not accept a
>>> historical
>>> revisions. It ignores the new data, so charmworld does the same. If
>>> this
>>> is the case, I think a new charm name is needed.
>>>
>>> --
>>> You received this bug notific...