ERROR messages are being unnecessarily and incorrectly translated

Bug #1209317 reported by Jay Bryant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Jay Bryant

Bug Description

I have found that there are numerous cases in the cinder.po file for the en_US locale where the message strings are being improperly translated. For instance, 'Failed to copy image to volume: %(volume_id)s, error: %(error)s" is translated to the message string "Failed to copy image to volume" which causes the rest of the error message to be truncated.

In the case of English translations it doesn't make sense to have the msgstr set. It should just be blank so that the appropriate message is printed.

Jay Bryant (jsbryant)
Changed in cinder:
assignee: nobody → Jay Bryant (jsbryant)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/40948

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/40948
Committed: http://github.com/openstack/cinder/commit/a78e3f7b0ed82fc8d4233e0fbfab849b73b69cee
Submitter: Jenkins
Branch: master

commit a78e3f7b0ed82fc8d4233e0fbfab849b73b69cee
Author: Jay S. Bryant <email address hidden>
Date: Wed Aug 21 16:39:04 2013 -0500

    Fix incorrect msgstr's to avoid translation errors

    There are numerous msgstr's in the cinder.po files for en_US,
    en_AU and en_GB that are incorrect translations of the associated
    msgid. It appears that there are a number that are the result of
    problems with past fuzzy translations gone wrong and some may also be the
    result of copy/paste mistakes. Regardless of the origin it makes debug and
    development very difficult if the string that is coming out in the
    logs doesn't match what is expected. This patch fixes the numerous
    bad msgstr's.

    Once this commit is merged, Transifex will catch the change to
    the Cinder po files and then spin a new Transifex Translations import.

    Fixes bug #1209317

    Change-Id: Ia78f5ebb4bec996798798bb25ea1b97c47b5e50b

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.