Heat config: all options related to binding should be splited from DEFAULT

Bug #1209141 reported by Emilien Macchi
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Angus Salkeld

Bug Description

In the new config fashion, all the flags related to binding are in DEFAULT section.

In the case where all Heat API running on the same node, that could be a problem. We should create group options on each API python file and maybe add a section for each API (api, cfn and cloudwatch).

Revision history for this message
Emilien Macchi (emilienm) wrote :

Example: binding options are on wsgi.py and use bind_* flag.

So if heat-api-cfn and heat-api-cloudwatch are on the same node, they use the same heat.conf, and then the process won't start since there will have a concurrency between api services on binding.

Maybe could we have sections like :

[DEFAULT]

[API]

[CFN]

[CLOUDWATCH]

...

Changed in heat:
status: New → Triaged
importance: Undecided → High
Angus Salkeld (asalkeld)
Changed in heat:
assignee: nobody → Angus Salkeld (asalkeld)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43697

Changed in heat:
status: Triaged → In Progress
Steven Hardy (shardy)
Changed in heat:
milestone: none → havana-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/43697
Committed: http://github.com/openstack/heat/commit/0d083f972a4e408323c5f2f6aa346842927194e9
Submitter: Jenkins
Branch: master

commit 0d083f972a4e408323c5f2f6aa346842927194e9
Author: Angus Salkeld <email address hidden>
Date: Tue Aug 27 10:26:53 2013 +1000

    Add the api config opts in groups to deal with the single heat.conf

    So first off, I also don't like the replicating of the api_opts in wsgi.py
    but if I don't do that the sample generator doesn't work:(

    We add the wsgi options into a group for each of the api servers with
    the deprecated group of "DEFAULT" so it still deals with the flat layout.

    The behaviour is as follows (assuming heat-api):
    1) if you have both (/etc/heat/{heat.conf, heat-api.conf}
       the value in heat-api.conf wins over heat.conf
    2) if you have just one of the config files but a value in both the
       [DEFAULT] section and the [heat-api] section then the value in heat-api
       wins.

    bug #1209141
    Change-Id: I66ddb3dca91d13b28e68dfb4306e94eb4e537fa7

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.