OpenStack Compute (nova)

instance consoleauth expired tokens need to be removed from the cache

Bug #1209134 reported by Yaguang Tang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Yaguang Tang
Grizzly
Fix Released
Undecided
Yaguang Tang
OpenStack Compute (nova) 2013.1.4

Bug Description

instance consoleauth tokens are stored in memory cache or memcached, the key is instance uuid and values are all tokens, before the instance is deleted, the tokens aren't deleted even through tokens are expired . therefore, there is the possibility that the value reach the max limit when using memcached

Yaguang Tang (heut2008)
Changed in nova:
assignee: nobody → Yaguang Tang (heut2008)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/41064

Matt Riedemann (mriedem)
Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/41064
Committed: http://github.com/openstack/nova/commit/e3bbf2e81137bbcdc39bdfb4c4ff62f30c37afda
Submitter: Jenkins
Branch: master

commit e3bbf2e81137bbcdc39bdfb4c4ff62f30c37afda
Author: Yaguang Tang <email address hidden>
Date: Wed Aug 7 17:06:54 2013 +0800

    Delete expired instance console auth tokens

    Instance console auth tokens never get deleted from the cache
    before the instnace is deleted, this is a waste of memory. now
    we check if tokens are expired then remove them from the cache
    before store new tokens.

    Fix bug #1209134

    Co-authored-by: Takashi Natsume <email address hidden>
    Change-Id: I8dd5089ebaed3b3d91932f1f1558bbe302cd5675

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/44782

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/grizzly)

Reviewed: https://review.openstack.org/44782
Committed: http://github.com/openstack/nova/commit/0e0f3a9f79cdb9f8394984859be46e898ed6d3a5
Submitter: Jenkins
Branch: stable/grizzly

commit 0e0f3a9f79cdb9f8394984859be46e898ed6d3a5
Author: Yaguang Tang <email address hidden>
Date: Wed Aug 7 17:06:54 2013 +0800

    Delete expired instance console auth tokens

    Instance console auth tokens never get deleted from the cache
    before the instnace is deleted, this is a waste of memory. now
    we check if tokens are expired then remove them from the cache
    before store new tokens.

    Fix bug #1209134

    Co-authored-by: Takashi Natsume <email address hidden>
    (cherry picked from commit e3bbf2e81137bbcdc39bdfb4c4ff62f30c37afda)
    Conflicts:
     nova/tests/consoleauth/test_consoleauth.py

    Change-Id: I8dd5089ebaed3b3d91932f1f1558bbe302cd5675

tags: added: in-stable-grizzly
Alan Pevec (apevec)
tags: removed: in-stable-grizzly
Changed in nova:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.