glance-replicator: handle circumstances when one of image properties is None

[Yufang Zhang]

In glance-replicator, all image properties in the master glance are synced to the slave glance. But there are circumstances( kernel_id or ramdisk_id, etc. ) when image properties in the master glance are None. Glance-relicator doesn't handle this issue, thus all such properties are trasnlated to the string 'None' in the slave glance, which is incorrect.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/40199

[Yufang Zhang (yufang521247)]

I check the mysql, here are some problematic entries:

mysql> select * from image_properties where name='kernel_id';
+-----+--------------------------------------+-----------+-------+---------------------+---------------------+------------+---------+
| id | image_id | name | value | created_at | updated_at | deleted_at | deleted |
+-----+--------------------------------------+-----------+-------+---------------------+---------------------+------------+---------+
| 7 | ac9990ad-b3ac-45ea-8c2e-ddf45dd10791 | kernel_id | None | 2013-08-05 08:02:52 | 2013-08-05 08:02:52 | NULL | 0 |
| 20 | bcb7fe30-0561-42ae-8adf-d0decc1dbe07 | kernel_id | None | 2013-08-05 08:11:04 | 2013-08-05 08:11:04 | NULL | 0 |

The value of kernel_id shoud be NULL instead of string 'None'.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/40199
Committed: http://github.com/openstack/glance/commit/ec07f0b437bef428a101073610e47f6b2c10dc1a
Submitter: Jenkins
Branch: master

commit ec07f0b437bef428a101073610e47f6b2c10dc1a
Author: Yufang Zhang <[e-mail]>
Date: Mon Aug 5 18:28:30 2013 +0800

    Handle None value properties in glance-replicator

    bug 1208417

    In glance-replicator, all image properties in the master glance are
    synced to the slave. But there are circumstances(kernel_id or
    ramdisk_id, etc.) when image properties in the master are None.
    glance-relicator doesn't handle this issue, thus all such properties
    are trasnlated to the string 'None' in the slave glance, which is
    incorrect.

    This patch fixes this problem by add a check before post metadata to
    the slave glance. All None properties are translated to '' before
    posted to slave glance.

    Change-Id: I9b674db907f707ac4dce28c8a7e3d81fcce61193

[Yang Yu (yuyangbj)]

I will be out of the office starting 2013-09-05 and will not return until
2013-09-15.

I will be on my marriage leave from 9/5 to 9/15, for any urgent issue
please call me before 9/7.

For daily work, please ask my scrum master Zhu Zhu for help.
For glance issue, please ask glance SME Feilong Wang for help.
For defect report, there will be no report next week.