The error msg of v2 image_data.py should be improved

Bug #1207616 reported by Feilong Wang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Undecided
Feilong Wang

Bug Description

Based on current implement, the error message during raising is missing the image id. See: https://github.com/openstack/glance/blob/master/glance/api/v2/image_data.py#L61

Besides, the error message of "dowload" should be logged as we did in upload to be consistent and improve the serviceability.

Feilong Wang (flwang)
Changed in glance:
status: New → In Progress
assignee: nobody → Fei Long Wang (flwang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/40092

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/40092
Committed: http://github.com/openstack/glance/commit/6a77498a989747c8e8970c8f5ccbdb5c70b9d0be
Submitter: Jenkins
Branch: master

commit 6a77498a989747c8e8970c8f5ccbdb5c70b9d0be
Author: Fei Long Wang <email address hidden>
Date: Sun Aug 4 15:54:41 2013 +0800

    Improve the error msg of v2 image_data.py

    Based on current implement, the error message of some upload
    failures is missing the image id. It looks like: 'Unable to
    upload duplicate image data for image: %s'.

    Fixes bug 1207616

    Change-Id: I608fb1ba84dde0e44a73e5e1bd3e850db49d84c4

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → havana-3
status: Fix Committed → Fix Released
Revision history for this message
Yang Yu (yuyangbj) wrote : I will be on vacation from 9/5 to 9/15, urgent call: 13811509950

I will be out of the office starting 2013-09-05 and will not return until
2013-09-15.

I will be on my marriage leave from 9/5 to 9/15, for any urgent issue
please call me before 9/7.

For daily work, please ask my scrum master Zhu Zhu for help.
For glance issue, please ask glance SME Feilong Wang for help.
For defect report, there will be no report next week.

Thierry Carrez (ttx)
Changed in glance:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.