Schema validation requires a more recent version of jsonschema than stated by requirements file

Bug #1207491 reported by Tim Simpson
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Medium
Denis M.

Bug Description

The method "validate_request" of trove.common.wsgi.Controller requires that the jsonschema.ValidationError object contains the attribute "context". This attribute is not present in jsonschema version 1.1.0 as discovered during CI testing at Rackspace.

There are two solutions.

One, we can check for the presence of the "context" attribute and, if it is missing, degrade the functionality of the validation error message generator a slight bit by not appending the additional error messages in error.context.

Two, we can change the requirements file to state jsonschema needs to be at least version 1.3.0, which is confirmed to work.

Requirement jsonschema>=1.3.0,!=1.4.0,<2 does not match openstack/requirements value jsonschema>=1.3.0,!=1.4.0

Changed in trove:
assignee: nobody → Nikhil Manchanda (slicknik)
importance: Undecided → Medium
Changed in trove:
assignee: Nikhil Manchanda (slicknik) → nobody
Denis M. (dmakogon)
Changed in trove:
assignee: nobody → Denis M. (dmakogon)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/44431

Changed in trove:
status: New → In Progress
Denis M. (dmakogon)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/44431
Committed: http://github.com/openstack/trove/commit/154639565ab9ab3bc66e8bd83e3ac1111a744fc3
Submitter: Jenkins
Branch: master

commit 154639565ab9ab3bc66e8bd83e3ac1111a744fc3
Author: Denis M <email address hidden>
Date: Fri Aug 30 13:13:30 2013 +0300

    jsonschema upgrade to v1.3.0(as minimal)

    Change-Id: I6478eeaa926a05d3ac45d08654eaa8d9eb7cd9f7
    Fixes: bug #1207491

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.