Empty domain names in navigation history
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
webbrowser-app |
Fix Released
|
High
|
Olivier Tilloy | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Steps to reproduce:
1) rm ~/.local/
2) rm ~/.cache/
3) Launch the browser, and wait for the home page to be loaded (ubuntu.com)
4) Open the activity view, and verify that the navigation history contains only one row ("Today") which itself contains one entry ("ubuntu.com")
5) Close the browser application
6) Launch the browser again, and open the activity view (no need to wait for the home page to be loaded)
Expected result: the navigation history contains only one row ("Today") which itself contains one entry ("ubuntu.com").
Current result: the navigation history contains all possible rows ("Yesterday", "Last 7 Days", "This Month", "This Year", "Older") and each of these rows contains a single entry ("ubuntu.com") that, when expanded, is empty.
Related branches
- PS Jenkins bot: Approve (continuous-integration)
- Günter Schwann (community): Approve
-
Diff: 115 lines (+8/-21)5 files modifiedsrc/Ubuntu/Components/Extras/Browser/history-domain-model.cpp (+1/-1)
src/Ubuntu/Components/Extras/Browser/history-domainlist-model.cpp (+3/-5)
src/Ubuntu/Components/Extras/Browser/history-timeframe-model.cpp (+2/-2)
tests/unittests/history-domainlist-model/tst_HistoryDomainListModelTests.cpp (+0/-13)
tests/unittests/history-timeframe-model/tst_HistoryTimeframeModelTests.cpp (+2/-0)
Changed in webbrowser-app: | |
status: | New → Confirmed |
Changed in webbrowser-app: | |
status: | Fix Committed → Fix Released |
This regression doesn’t seem to have been introduced when we started sorting domain names chronologically. stChronological Model in TimelineView.qml, using the HistoryDomainLi stModel as a model directly, and I’m still seeing the same issue.
For a quick test, I commented out the use of HistoryDomainLi