wrong argument when calling saft_utils.getcallargs() in nova/exception.py

[David Xie]

When calling live-migration on nova and it failes, nova will try to send a notification. However, this notification sends wrong parameters then.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/39633

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/39633
Committed: http://github.com/openstack/nova/commit/32b1aa24a6f45bd00165820f8b6e342ddc2867b6
Submitter: Jenkins
Branch: master

commit 32b1aa24a6f45bd00165820f8b6e342ddc2867b6
Author: David Xie <email address hidden>
Date: Wed Sep 11 21:54:47 2013 +0800

    Wrong arguments when calling safe_utils.getcallargs()

    When calling safe_utils.getcallargs(), it will get all argnames from
    definition of a function. As every function in Nova has a argument named
    `context`, so argnames will always start with `context`.

    In nova/exception.py#81, *args is a list of arguments which does not
    start with
    `context`, however, argnames starts with `context`, this will lead to a
    mismatching when zip it into a dict.

    Solution for this is that when calling getcallargs(), pass context as
    one argument.

    Change-Id: I4ce81e1862fb2d741f15747b04aa6bf1a2243364
    Fixes: bug #1207153