comments from NEW review
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
unity-china-video-scope |
Fix Released
|
High
|
shijing | ||
unity-china-video-scope (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
I'm reviewing that package in the saucy NEW queue, some comments:
* the debian directory contains a "unity-
* compat is "8" but control has a build-depends on debhelper (>= 9), you can bump the compat to 9
* you use valac-0.18, would be nicer to build-depends on "valac" so it follows the default version (current 0.20)
* debian/control has:
"# If you aren't a member of ~unity-team but need to upload packaging changes,
# just go ahead. ~unity-team will notice and sync up the code again."
* debian/copyright:
Copyright: <2012> <Pawel Stolowski <email address hidden>>
that should be "Copyright (C) 2012 Canonical Ltd"
None of those are blockers to get in saucy, I'm accepting the source, but it would be nice to fix those issues in the next upload
Related branches
Changed in unity-china-video-scope: | |
status: | New → Fix Committed |
Changed in unity-china-video-scope: | |
status: | Fix Committed → Fix Released |
Thanks. These comments will be included in the next release.