comments from NEW review

Bug #1206613 reported by Sebastien Bacher
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-china-video-scope
Fix Released
High
shijing
unity-china-video-scope (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

I'm reviewing that package in the saucy NEW queue, some comments:

* the debian directory contains a "unity-china-video-scope.pkg" subdirectory that seems to be a copy of the debian directory, that seems wrong

* compat is "8" but control has a build-depends on debhelper (>= 9), you can bump the compat to 9

* you use valac-0.18, would be nicer to build-depends on "valac" so it follows the default version (current 0.20)

* debian/control has:

"# If you aren't a member of ~unity-team but need to upload packaging changes,
# just go ahead. ~unity-team will notice and sync up the code again."

* debian/copyright:
Copyright: <2012> <Pawel Stolowski <email address hidden>>

that should be "Copyright (C) 2012 Canonical Ltd"

None of those are blockers to get in saucy, I'm accepting the source, but it would be nice to fix those issues in the next upload

Revision history for this message
Jack Yu (jackyu) wrote :

Thanks. These comments will be included in the next release.

Changed in unity-china-video-scope:
importance: Undecided → High
assignee: nobody → shijing (jingjing20061278)
milestone: none → 1.2
Revision history for this message
shijing (shijing) wrote :

All the bugs have fixed!

Jack Yu (jackyu)
Changed in unity-china-video-scope:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-china-video-scope - 1.1-0ubuntu2

---------------
unity-china-video-scope (1.1-0ubuntu2) saucy; urgency=low

  * Fix several minor issues from new review (LP: #1206613)
 -- Jeremy Bicha <email address hidden> Thu, 29 Aug 2013 00:48:51 -0400

Changed in unity-china-video-scope (Ubuntu):
status: New → Fix Released
Jack Yu (jackyu)
Changed in unity-china-video-scope:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.