Duplicate declaration: Database_user[keystone@127.0.0.1] is already declared

[Xingchao Yu]

When use the default value of allowed_hosts in openstack:all and openstack::controller, the puppet will complain:
err: Could not retrieve catalog from remote server: Error 400 on SERVER: Duplicate declaration: Database_user[glance@127.0.0.1] is already declared; cannot redeclare at /etc/puppet/modules/production/glance/manifests/db/mysql/host_access.pp:9 on node m1.novalocal
warning: Not using cache on failed catalog
err: Could not retrieve catalog; skipping run

The reason is the Database_user[xxx@127.0.0.1] has been created when the default db is created. So there needs a condition to decide not to add hosts when $hosts's value in $allowed_hosts.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/39260

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/39261

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/39263

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/39263
Committed: http://github.com/stackforge/puppet-glance/commit/aee08d0cbbf3f8c13040dbf6abc652f678b88f37
Submitter: Jenkins
Branch: master

commit aee08d0cbbf3f8c13040dbf6abc652f678b88f37
Author: Xingchao Yu <email address hidden>
Date: Tue Jul 30 19:04:34 2013 +0800

    Update allowed_hosts conditional statement

    In the origin glance::db::mysql, if the value of $allowed_hosts
    contains or equals to $host, then puppet will complain duplicate
    declaration error. This patch is aim to update the allowed_hosts
    conditonal statement in glance::db::mysql.

    There are two cases to pass $allowed_hosts to $real_allowed_hosts:

       - If $allowed_hosts is array,then remove $host from $allowed_hosts;
       - elsif $allowed_hosts is string and not equivalent to $host;

    At last, if $real_allowed_hosts is not undef, then run
    glance::db::mysql::host_access

    Fix bug 1206444

    Change-Id: Ic70aaaec493195c7277782abb87469f9809e5baa

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/39639

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/39261
Committed: http://github.com/stackforge/puppet-cinder/commit/e7657de5ba6d7c2c122e1bc99598683f4a7021f3
Submitter: Jenkins
Branch: master

commit e7657de5ba6d7c2c122e1bc99598683f4a7021f3
Author: Xingchao Yu <email address hidden>
Date: Tue Jul 30 18:51:05 2013 +0800

    Update allowed_hosts conditional statement

    In the origin cinder::db::mysql, if the value of $allowed_hosts
    contains or equals to $host, then puppet will complain duplicate
    declaration error. This patch is aim to update the allowed_hosts
    conditonal statement in cinder::db::mysql.

    There are two cases to pass $allowed_hosts to $real_allowed_hosts:

       - If $allowed_hosts is array,then remove $host from $allowed_hosts;
       - elsif $allowed_hosts is string and not equivalent to $host;

    At last, if $real_allowed_hosts is not undef, then run
    cinder::db::mysql::host_access

    Fix bug 1206444
    Change-Id: I7eb9d883c1617d9913899f32ef47a892c1d9a1a2

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/39260
Committed: http://github.com/stackforge/puppet-nova/commit/e8cebd12f385cda9dfedf97b0c6b0e25e5bf7198
Submitter: Jenkins
Branch: master

commit e8cebd12f385cda9dfedf97b0c6b0e25e5bf7198
Author: Xingchao Yu <email address hidden>
Date: Tue Jul 30 18:40:19 2013 +0800

    Update allowed_hosts conditional statement

    In the origin nova::db::mysql, if the value of $allowed_hosts
    contains or equals to $host, then puppet will complain duplicate
    declaration error. This patch is aim to update the allowed_hosts
    conditonal statement in nova::db::mysql.

    There are two cases to pass $allowed_hosts to $real_allowed_hosts:

       - If $allowed_hosts is array,then remove $host from $allowed_hosts;
       - elsif $allowed_hosts is string and not equivalent to $host;

    At last, if $real_allowed_hosts is not undef, then run
    nova::db::mysql::host_access

    Fix bug 1206444
    Change-Id: If018321095e62e1196e0c2e6b623b30acb535020

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/39256
Committed: http://github.com/stackforge/puppet-keystone/commit/49b248344f40d61ae7467f1f35547e39d66517ed
Submitter: Jenkins
Branch: master

commit 49b248344f40d61ae7467f1f35547e39d66517ed
Author: Xingchao Yu <email address hidden>
Date: Tue Jul 30 18:03:22 2013 +0800

    Update allowed_hosts conditional statement

    In the origin keystone::db::mysql, if the value of $allowed_hosts
    contains or equals to $host, then puppet will complain duplicate
    declaration error. This patch is aim to update the allowed_hosts
    conditonal statement in keystone::db::mysql.

    There are two cases to pass $allowed_hosts to $real_allowed_hosts:

       - If $allowed_hosts is array,then remove $host from $allowed_hosts;
       - elsif $allowed_hosts is string and not equivalent to $host;

    At last, if $real_allowed_hosts is not undef, then run
    keystone::db::mysql::host_access

    Fix bug 1206444

    Change-Id: I8701aea9344a9151ce3d7ac8fa5792895a5aac6c

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/39639
Committed: http://github.com/stackforge/puppet-quantum/commit/af3982695f0162f7587b7279df66fbe158817705
Submitter: Jenkins
Branch: master

commit af3982695f0162f7587b7279df66fbe158817705
Author: Xingchao Yu <email address hidden>
Date: Thu Aug 1 15:04:58 2013 +0800

    Update allowed_hosts conditional statement

    In the origin quantum::db::mysql, if the value of $allowed_hosts
    contains or equals to $host, then puppet will complain duplicate
    declaration error. This patch is aim to update the allowed_hosts
    conditonal statement in quantum::db::mysql.

    There are two cases to pass $allowed_hosts to $real_allowed_hosts:

       - If $allowed_hosts is array,then remove $host from $allowed_hosts;
       - elsif $allowed_hosts is string and not equivalent to $host;

    At last, if $real_allowed_hosts is not undef, then run
    quantum::db::mysql::host_access

    Fix bug 1206444

    Change-Id: I4c7aef5b7c002c799e8c78fc45dfc3362d41d6ee

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/40099

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/40165

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/40099
Committed: http://github.com/stackforge/puppet-ceilometer/commit/10107796ff2751da858a4616f97e6e3166ec40a8
Submitter: Jenkins
Branch: master

commit 10107796ff2751da858a4616f97e6e3166ec40a8
Author: Xingchao Yu <email address hidden>
Date: Sun Aug 4 17:09:06 2013 +0800

    Update mysql allowed_hosts conditional statement

    In the origin ceilometer::db::mysql, if the value of $allowed_hosts
    contains or equals to $host, then puppet will complain duplicate
    declaration error. This patch is aim to update the allowed_hosts
    conditonal statement in ceilometer::db::mysql.

    There are two cases to pass $allowed_hosts to $real_allowed_hosts:

       - If $allowed_hosts is array,then remove $host from $allowed_hosts;
       - elsif $allowed_hosts is string and not equivalent to $host;

    At last, if $real_allowed_hosts is not undef, then run
    ceilometer::db::mysql::host_access

    Fix bug 1206444

    Change-Id: Ib6c33e6a27113d01326bee32c105fea4003059ce

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/40165
Committed: http://github.com/stackforge/puppet-heat/commit/e9e261be3bbff99ae95786e9b2089712bfc03eb4
Submitter: Jenkins
Branch: master

commit e9e261be3bbff99ae95786e9b2089712bfc03eb4
Author: Xingchao Yu <email address hidden>
Date: Sun Aug 4 17:57:42 2013 +0800

    Update allowed_hosts conditional statement

    In the origin heat::db::mysql, if the value of $allowed_hosts
    contains or equals to $host, then puppet will complain duplicate
    declaration error. This patch is aim to update the allowed_hosts
    conditonal statement in heat::db::mysql.

    There are two cases to pass $allowed_hosts to $real_allowed_hosts:

       - If $allowed_hosts is array,then remove $host from $allowed_hosts;
       - elsif $allowed_hosts is string and not equivalent to $host;

    At last, if $real_allowed_hosts is not undef, then run
    heat::db::mysql::host_access

    Add heat_db_mysql_spec for related test.

    Fix bug 1206444

    Change-Id: Iac6a32fb614c9ad19f9eaa3aaa883cb3bf9aa2ef