Post claim with negative int for TTL/ grace

Bug #1206175 reported by Malini Kamalambal
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
Undecided
Unassigned

Bug Description

Steps to repro:
Post a claim with a negative value for TTL (or) Grace.

(System Test: test_claims.py:test_011_claim_negative_int in https://review.openstack.org/#/c/39114)

Expected Result:
Server will return a http response code 400

Actual Result:
Server returns a http response code 404

Revision history for this message
Zhihao Yuan (zyuan) wrote :

404 means that your queue does not exist yet. IMHO, system test should be more presice on capturing bugs...

Before input-validation is there, this is not implemented yet.

Changed in marconi:
status: New → Confirmed
Revision history for this message
Malini Kamalambal (malini-pk) wrote :

'404 means that your queue does not exist yet'--> Doesn't look like the code behaves, as per zyuan's definition
' IMHO, system test should be more presice on capturing bugs...' --> IMHO the tests should be run, before making such blanket statements.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to marconi (master)

Reviewed: https://review.openstack.org/38588
Committed: http://github.com/stackforge/marconi/commit/f1e71796b4a0436c2728e92c28979c5ca4d5d144
Submitter: Jenkins
Branch: master

commit f1e71796b4a0436c2728e92c28979c5ca4d5d144
Author: Zhihao Yuan <email address hidden>
Date: Thu Jul 25 02:36:57 2013 -0400

    feat(validation): validate user input

    The validation is implemented as a set of free-standing functions
    in a separated module; each driver which uses storage functions
    should call call the corresponding validation functions first.

    Fixes: bug #1177971
    Fixes: bug #1177976
    Fixes: bug #1177979
    Fixes: bug #1206175
    Fixes: bug #1208873

    Change-Id: I0b9c9766a9c3de42f2a2eb470cba0ab7265e669a

Changed in marconi:
status: Confirmed → Fix Committed
Changed in marconi:
milestone: none → havana-2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.