Database schema migrations tests aren't run for MySQL and PostgreSQL backends by Jenkins gate. This is due to the bug in _get_connect_string() function:
def _get_connect_string(backend,
user="openstack_citest",
passwd="openstack_citest",
database="openstack_citest"):
"""
Try to get a connection with a very specific set of values, if we get
these then we'll run the tests, otherwise they are skipped
"""
if backend == "postgres":
backend = "postgresql+psycopg2"
return ("%(backend)s://%(user)s:%(passwd)s@localhost/%(database)s",
{'backend': backend, 'user': user, 'passwd': passwd,
'database': database})
This function is supposed to return a database connection string, but % operator is missed, so a tuple will be returned instead. The return value is used in _is_backend_avail() function:
def _is_backend_avail(backend,
user="openstack_citest",
passwd="openstack_citest",
database="openstack_citest"):
try:
if backend == "mysql":
connect_uri = _get_connect_string("mysql", user=user,
passwd=passwd, database=database)
elif backend == "postgres":
connect_uri = _get_connect_string("postgres", user=user,
passwd=passwd, database=database)
engine = sqlalchemy.create_engine(connect_uri)
connection = engine.connect()
except Exception:
# intentionally catch all to handle exceptions even if we don't
# have any backend code loaded.
return False
else:
connection.close()
engine.dispose()
return True
_is_backend_avail() excepts a too general exception, so the actual error is interpreted incorrectly (as if a DB backend wasn't available), so the test is skipped.
The regression was introduced in 729a08a019837bf4a5cbce5eee46a0a6e8e12acd.
Fix proposed to branch: master
Review: https:/