neutron.agent.l3_agent:Failed synchronizing routers in UT

[Eugene Nikanorov]

Sometimes full run of Unit Tests ends with the following output:
 ERROR:neutron.agent.l3_agent:Failed synchronizing routers
 Traceback (most recent call last):
   File "/home/jenkins/workspace/gate-neutron-python27/neutron/agent/l3_agent.py", line 685, in _rpc_loop
     self._process_router_delete()
   File "/home/jenkins/workspace/gate-neutron-python27/neutron/agent/l3_agent.py", line 693, in _process_router_delete
     self._router_removed(router_id)
   File "/home/jenkins/workspace/gate-neutron-python27/neutron/agent/l3_agent.py", line 289, in _router_removed
     ri = self.router_info[router_id]
 KeyError: '0393021f-e20b-4c93-8bf6-e4c5ecd9b06e'

Tests pass at the same time, so Jenkins is not catching issues.
First noticed afterfix for gate issue with floating ips was merged: https://review.openstack.org/#/c/36890/

[Eugene Nikanorov (enikanorov)]

I believe this bug is a result of still existing race condition in l3_agent

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/38703

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/38703
Committed: http://github.com/openstack/neutron/commit/0f4f3150f4c2a2bba8712e3439a02337eb726a2b
Submitter: Jenkins
Branch: master

commit 0f4f3150f4c2a2bba8712e3439a02337eb726a2b
Author: Eugene Nikanorov <email address hidden>
Date: Fri Jul 26 00:45:10 2013 +0400

    Fix l3_agent unit tests

    Mock FixedIntervalLoopingCall in unit tests so
    _rpc_loop doesn't interfere with the tests

    fixes bug 1205085

    Change-Id: I54cc152890734afc7a5b86dd9ae4ea133bd7574b