collect requires 2 database handles when storing raw events

Bug #1204520 reported by Doug Hellmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
Nejc Saje

Bug Description

When we set up the raw event storage code, I suggested just putting it in the CollectorService directly. Then somewhere along the way we moved the notification handling into a class invoked through a dispatcher, so the CollectorService no longer has a database handle. Bug #1204133 reported that problem, and is being fixed in a short-term way by adding a second database handle. However, to remove that extra database connection and to treat the raw notification data consistently with the notifications, we should update the dispatcher to have the necessary methods and then move the logic for storing the event into the DatabaseDispatcher class.

Nejc Saje (nejc-saje)
Changed in ceilometer:
assignee: nobody → Nejc Saje (nejc-saje)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/40867

Changed in ceilometer:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/40867
Committed: http://github.com/openstack/ceilometer/commit/fd61f630e9db7589b01a89c7cb4f7d6e5e62ee3a
Submitter: Jenkins
Branch: master

commit fd61f630e9db7589b01a89c7cb4f7d6e5e62ee3a
Author: Nejc Saje <email address hidden>
Date: Thu Aug 8 13:39:47 2013 +0200

    Storing events via dispatchers

    Removes the database handle from CollectorService and
    moves the logic for storing events to Dispatcher classes.

    Change-Id: I22cf02685e3a33a9014d65d8d32a5b585dabe185
    Fixes: bug #1204520

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.