horizon exceptions always get extra characters inserted for coloring

Bug #1203890 reported by Eric Peterson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Eric Peterson

Bug Description

in horizon/exceptions.py there are several references to error_color().

When django is correctly configured to use no color highlighting, horizon is still inserting colors for log messages using the django dark color pallete.

This causes a bunch of garbage characters in a variety of log situations. The handle method has no business inserting color characters - this is a log formatting exercrise.

Changed in horizon:
assignee: nobody → Eric Peterson (ericpeterson-l)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/38217

Changed in horizon:
status: New → In Progress
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Medium
Changed in horizon:
milestone: none → havana-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/38217
Committed: http://github.com/openstack/horizon/commit/f601a331f48c3508566ebce4c8ce38e493f7ab5c
Submitter: Jenkins
Branch: master

commit f601a331f48c3508566ebce4c8ce38e493f7ab5c
Author: ericpeterson-l <email address hidden>
Date: Mon Jul 22 16:31:15 2013 -0600

    removing horizon exceptions adding colors to log messages

    Change-Id: I271a1a83e56913a369fcb25d8e51ebed8b57c943
    Fixes: bug #1203890

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.