EC2 Client Tokens don't work yet

[Burt Holzman]

I'm not sure how this ever worked for me in a live devstack install -- maybe I had things configured strangely.

The issue is that both vm_state and task_state are 'building', while neither of those are allowed currently by
update_instance_metadata. If I allow that, it complicates matters since there's an rpcapi call for change_instance_metadata -- so the instance can access its own metadata, I guess.

I'm not sure of the right approach yet.

This needs tests in tempest too.

[Burt Holzman (holzman)]

Sorry -- meant to say the vm_state is 'building'. Task_state is probably scheduling.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/37627

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/37630

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/37684

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/37687

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/37838

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/37687
Committed: http://github.com/openstack/nova/commit/0608c6f936ef7466114128fbc4b623c5058b66ed
Submitter: Jenkins
Branch: master

commit 0608c6f936ef7466114128fbc4b623c5058b66ed
Author: Burt Holzman <email address hidden>
Date: Wed Jul 17 17:03:27 2013 -0500

    Change EC2 client tokens to use system_metadata

    An EC2 client token is created as a result of RunInstances. The initial
    implementation called create_tags which uses per-instance metadata.
    However, we can't update per-instance metadata while an instance is still
    building because put the metadata updates in the messaging queue.

    We avoid this problem by using system_metadata instead of per-instance
    metadata. As an added bonus, users can't tamper with the token via the tags
    API.

    Fixes bug #1202404

    Change-Id: I8ff28d75154a30fe3b521926453b9e9cbdd9fead

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/37838
Committed: http://github.com/openstack/tempest/commit/f70f2220f729cbf8e1df317d6d3a439bd861f06f
Submitter: Jenkins
Branch: master

commit f70f2220f729cbf8e1df317d6d3a439bd861f06f
Author: Burt Holzman <email address hidden>
Date: Thu Jul 18 23:36:31 2013 -0500

    Add boto tests for idempotent RunInstances calls

    The EC2 API supports providing a unique client token to
    the RunInstances call to ensure idempotency. In other words,
    multiple RunInstances call with the same client token will
    not start up multiple instances.

    This adds a test for this condition, including ensuring that
    a new instance is spawned when a client token is re-used
    after the original instance linked to it has been terminated.

    Fixes bug #1202404

    Change-Id: Ia11eb9ac082a623a1ad03b89fb6dbf7cad9f9c99